Browse Source

test: remove test repetition

Remove loops executing the same tests multiple times.

PR-URL: https://github.com/nodejs/io.js/pull/1874
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
v2.3.1-release
Rich Trott 10 years ago
parent
commit
88d7904c0b
  1. 36
      test/parallel/test-buffer.js

36
test/parallel/test-buffer.js

@ -271,35 +271,31 @@ assert.equal(writeTest.toString(), 'nodejs');
var asciiString = 'hello world'; var asciiString = 'hello world';
var offset = 100; var offset = 100;
for (var j = 0; j < 500; j++) {
for (var i = 0; i < asciiString.length; i++) { for (var i = 0; i < asciiString.length; i++) {
b[i] = asciiString.charCodeAt(i); b[i] = asciiString.charCodeAt(i);
} }
var asciiSlice = b.toString('ascii', 0, asciiString.length); var asciiSlice = b.toString('ascii', 0, asciiString.length);
assert.equal(asciiString, asciiSlice); assert.equal(asciiString, asciiSlice);
var written = b.write(asciiString, offset, 'ascii'); var written = b.write(asciiString, offset, 'ascii');
assert.equal(asciiString.length, written); assert.equal(asciiString.length, written);
var asciiSlice = b.toString('ascii', offset, offset + asciiString.length); var asciiSlice = b.toString('ascii', offset, offset + asciiString.length);
assert.equal(asciiString, asciiSlice); assert.equal(asciiString, asciiSlice);
var sliceA = b.slice(offset, offset + asciiString.length); var sliceA = b.slice(offset, offset + asciiString.length);
var sliceB = b.slice(offset, offset + asciiString.length); var sliceB = b.slice(offset, offset + asciiString.length);
for (var i = 0; i < asciiString.length; i++) { for (var i = 0; i < asciiString.length; i++) {
assert.equal(sliceA[i], sliceB[i]); assert.equal(sliceA[i], sliceB[i]);
}
// TODO utf8 slice tests
} }
// TODO utf8 slice tests
for (var j = 0; j < 100; j++) { var slice = b.slice(100, 150);
var slice = b.slice(100, 150); assert.equal(50, slice.length);
assert.equal(50, slice.length); for (var i = 0; i < 50; i++) {
for (var i = 0; i < 50; i++) {
assert.equal(b[100 + i], slice[i]); assert.equal(b[100 + i], slice[i]);
}
} }

Loading…
Cancel
Save