Browse Source

src: move node_trace_writer/buffer.h to agent.cc

The headers node_trace_writer.h and node_trace_buffer.h are not used in
agent.h but are more of an implementation detail of agent.cc.

This commit suggests moving the inclusion of these headers to agent.cc.

PR-URL: https://github.com/nodejs/node/pull/15598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
canary-base
Daniel Bevenius 7 years ago
parent
commit
8a6f376e36
  1. 2
      src/tracing/agent.cc
  2. 5
      src/tracing/agent.h

2
src/tracing/agent.cc

@ -2,6 +2,8 @@
#include <sstream>
#include <string>
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"
#include "env-inl.h"

5
src/tracing/agent.h

@ -1,15 +1,16 @@
#ifndef SRC_TRACING_AGENT_H_
#define SRC_TRACING_AGENT_H_
#include "libplatform/v8-tracing.h"
#include "node_platform.h"
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"
#include "uv.h"
#include "v8.h"
namespace node {
namespace tracing {
using v8::platform::tracing::TracingController;
class Agent {
public:
Agent();

Loading…
Cancel
Save