mirror of https://github.com/lukechilds/node.git
Browse Source
15157c3c3d
changed the CLI REPL
to default to useGlobal: false by default. This caused the
regression seen in https://github.com/nodejs/node/issues/7788.
This commit adds a known issue test while a proper resolution
is determined.
Refs: https://github.com/nodejs/node/pull/5703
Refs: https://github.com/nodejs/node/issues/7788
PR-URL: https://github.com/nodejs/node/pull/7793
Reviewed-By: Rich Trott <rtrott@gmail.com>
v7.x
cjihrig
9 years ago
2 changed files with 34 additions and 0 deletions
@ -0,0 +1,2 @@ |
|||
'use strict'; |
|||
module.exports.isObject = (obj) => obj.constructor === Object; |
@ -0,0 +1,32 @@ |
|||
'use strict'; |
|||
// Refs: https://github.com/nodejs/node/issues/7788
|
|||
const common = require('../common'); |
|||
const assert = require('assert'); |
|||
const path = require('path'); |
|||
const repl = require('repl'); |
|||
const stream = require('stream'); |
|||
const inputStream = new stream.PassThrough(); |
|||
const outputStream = new stream.PassThrough(); |
|||
const fixture = path.join(common.fixturesDir, 'is-object.js'); |
|||
const r = repl.start({ |
|||
input: inputStream, |
|||
output: outputStream, |
|||
useGlobal: false |
|||
}); |
|||
|
|||
let output = ''; |
|||
outputStream.setEncoding('utf8'); |
|||
outputStream.on('data', (data) => output += data); |
|||
|
|||
r.on('exit', common.mustCall(() => { |
|||
const results = output.split('\n').map((line) => { |
|||
return line.replace(/\w*>\w*/, '').trim(); |
|||
}); |
|||
|
|||
assert.deepStrictEqual(results, ['undefined', 'true', 'true', '']); |
|||
})); |
|||
|
|||
inputStream.write('const isObject = (obj) => obj.constructor === Object;\n'); |
|||
inputStream.write('isObject({});\n'); |
|||
inputStream.write(`require('${fixture}').isObject({});\n`); |
|||
r.close(); |
Loading…
Reference in new issue