Browse Source

test: fix `test-cluster-worker-kill`

Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: https://github.com/nodejs/node/pull/5814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
process-exit-stdio-flushing
Santiago Gimeno 9 years ago
committed by James M Snell
parent
commit
8d394810e8
  1. 21
      test/parallel/test-cluster-worker-kill.js

21
test/parallel/test-cluster-worker-kill.js

@ -60,8 +60,6 @@ if (cluster.isWorker) {
results.cluster_exitCode = worker.process.exitCode; results.cluster_exitCode = worker.process.exitCode;
results.cluster_signalCode = worker.process.signalCode; results.cluster_signalCode = worker.process.signalCode;
results.cluster_emitExit += 1; results.cluster_emitExit += 1;
assert.ok(results.cluster_emitDisconnect,
"cluster: 'exit' event before 'disconnect' event");
}); });
// Check worker events and properties // Check worker events and properties
@ -77,26 +75,11 @@ if (cluster.isWorker) {
results.worker_signalCode = signalCode; results.worker_signalCode = signalCode;
results.worker_emitExit += 1; results.worker_emitExit += 1;
results.worker_died = !alive(worker.process.pid); results.worker_died = !alive(worker.process.pid);
assert.ok(results.worker_emitDisconnect,
"worker: 'exit' event before 'disconnect' event");
process.nextTick(function() { finish_test(); });
}); });
var finish_test = function() { process.on('exit', function() {
try {
checkResults(expected_results, results); checkResults(expected_results, results);
} catch (exc) { });
console.error('FAIL: ' + exc.message);
if (exc.name != 'AssertionError') {
console.trace(exc);
}
process.exit(1);
return;
}
process.exit(0);
};
} }
// some helper functions ... // some helper functions ...

Loading…
Cancel
Save