mirror of https://github.com/lukechilds/node.git
Browse Source
cluster's internal message handling includes a cache of callback functions. Once the message for that callback is received, it is removed from the cache. If, for any reason, the same message ID is processed twice, the callback will be missing from the cache and cluster will try to call undefined as a function. This commit guards against this scenario. Refs: https://github.com/nodejs/node/issues/6561 PR-URL: https://github.com/nodejs/node/pull/6902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>v6.x
committed by
Rod Vagg
2 changed files with 23 additions and 1 deletions
@ -0,0 +1,22 @@ |
|||
'use strict'; |
|||
const common = require('../common'); |
|||
const assert = require('assert'); |
|||
const cluster = require('cluster'); |
|||
|
|||
if (cluster.isMaster) { |
|||
const worker = cluster.fork(); |
|||
|
|||
worker.on('exit', common.mustCall((code, signal) => { |
|||
assert.strictEqual(code, 0); |
|||
assert.strictEqual(signal, null); |
|||
})); |
|||
|
|||
worker.on('online', () => { |
|||
worker.send({ |
|||
cmd: 'NODE_CLUSTER', |
|||
ack: -1 |
|||
}, () => { |
|||
worker.disconnect(); |
|||
}); |
|||
}); |
|||
} |
Loading…
Reference in new issue