Browse Source

test: refactor test-debug-prompt

* Use cleaner `process.stdin.write('.exit')` to exit the process rather
  than `proc.kill()`.
* Move test to sequential. It uses the default port 9229. It will fail
  if another inspector test (or test using port 0) is already using that
  port. So it needs to be run sequentially rather than in parallel with
  other tests. (We haven't seen many failures with it yet because there
  aren't a lot of other inspector tests in parallel at this time.)

PR-URL: https://github.com/nodejs/node/pull/15141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
canary-base
Rich Trott 7 years ago
committed by Ruben Bridgewater
parent
commit
a172b7c51e
No known key found for this signature in database GPG Key ID: F07496B3EB3C1762
  1. 2
      test/sequential/test-debug-prompt.js

2
test/parallel/test-debug-prompt.js → test/sequential/test-debug-prompt.js

@ -11,5 +11,5 @@ let output = '';
proc.stdout.on('data', (data) => {
output += data;
if (output.includes('debug> '))
proc.kill();
proc.stdin.write('.exit\n');
});
Loading…
Cancel
Save