Browse Source

test: refactor large event emitter tests

This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: https://github.com/nodejs/node/pull/6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v4.x
cjihrig 9 years ago
committed by Myles Borins
parent
commit
aebbc965f9
  1. 16
      test/parallel/test-event-emitter-remove-listeners.js

16
test/parallel/test-event-emitter-remove-listeners.js

@ -1,13 +1,13 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const EventEmitter = require('events'); const events = require('events');
function listener1() {} function listener1() {}
function listener2() {} function listener2() {}
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
ee.on('hello', listener1); ee.on('hello', listener1);
ee.on('removeListener', common.mustCall((name, cb) => { ee.on('removeListener', common.mustCall((name, cb) => {
assert.strictEqual(name, 'hello'); assert.strictEqual(name, 'hello');
@ -18,7 +18,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
ee.on('hello', listener1); ee.on('hello', listener1);
ee.on('removeListener', common.fail); ee.on('removeListener', common.fail);
ee.removeListener('hello', listener2); ee.removeListener('hello', listener2);
@ -26,7 +26,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
ee.on('hello', listener1); ee.on('hello', listener1);
ee.on('hello', listener2); ee.on('hello', listener2);
ee.once('removeListener', common.mustCall((name, cb) => { ee.once('removeListener', common.mustCall((name, cb) => {
@ -46,7 +46,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
function remove1() { function remove1() {
common.fail('remove1 should not have been called'); common.fail('remove1 should not have been called');
@ -67,7 +67,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
ee.on('hello', listener1); ee.on('hello', listener1);
ee.on('hello', listener2); ee.on('hello', listener2);
ee.once('removeListener', common.mustCall((name, cb) => { ee.once('removeListener', common.mustCall((name, cb) => {
@ -87,7 +87,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
const listener3 = common.mustCall(() => { const listener3 = common.mustCall(() => {
ee.removeListener('hello', listener4); ee.removeListener('hello', listener4);
}, 2); }, 2);
@ -106,7 +106,7 @@ function listener2() {}
} }
{ {
const ee = new EventEmitter(); const ee = new events.EventEmitter();
ee.once('hello', listener1); ee.once('hello', listener1);
ee.on('removeListener', common.mustCall((eventName, listener) => { ee.on('removeListener', common.mustCall((eventName, listener) => {

Loading…
Cancel
Save