Browse Source

Fix test-net-server-on-fd-0 for windows by removing assert

Rename to regression test for GH-746 as the fd 0 behavior was not what the
bug report was about.
v0.7.4-release
Ryan Dahl 14 years ago
parent
commit
b3bc009a89
  1. 1
      Makefile
  2. 4
      test/simple/test-regress-GH-746.js

1
Makefile

@ -185,6 +185,7 @@ UVTEST += simple/test-readdouble
UVTEST += simple/test-readfloat UVTEST += simple/test-readfloat
UVTEST += simple/test-readint UVTEST += simple/test-readint
UVTEST += simple/test-readuint UVTEST += simple/test-readuint
UVTEST += simple/test-regress-GH-746
UVTEST += simple/test-regress-GH-819 UVTEST += simple/test-regress-GH-819
UVTEST += simple/test-regress-GH-897 UVTEST += simple/test-regress-GH-897
UVTEST += simple/test-regression-object-prototype UVTEST += simple/test-regression-object-prototype

4
test/simple/test-net-server-on-fd-0.js → test/simple/test-regress-GH-746.js

@ -19,6 +19,9 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
// Just test that destroying stdin doesn't mess up listening on a server.
// This is a regression test for GH-746.
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var net = require('net'); var net = require('net');
@ -36,7 +39,6 @@ var server = net.createServer(function(socket) {
server.listen(common.PORT, function() { server.listen(common.PORT, function() {
console.log('listening...'); console.log('listening...');
assert.equal(server.fd, 0);
net.createConnection(common.PORT); net.createConnection(common.PORT);
}); });
Loading…
Cancel
Save