Browse Source

net: remove implicit setting of DNS hints

This commit removes the implicit setting of the V4MAPPED and
ADDRCONFIG DNS flags in createConnection(). As of
39de601e1c, users that need these
flags can set them explicitly.

PR-URL: https://github.com/nodejs/node/pull/6021
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
process-exit-stdio-flushing
cjihrig 9 years ago
parent
commit
b85a50b6da
  1. 11
      lib/net.js

11
lib/net.js

@ -949,17 +949,6 @@ function lookupAndConnect(self, options) {
hints: options.hints || 0 hints: options.hints || 0
}; };
if (dnsopts.family !== 4 && dnsopts.family !== 6 && dnsopts.hints === 0) {
dnsopts.hints = dns.ADDRCONFIG;
// The AI_V4MAPPED hint is not supported on FreeBSD or Android,
// and getaddrinfo returns EAI_BADFLAGS. However, it seems to be
// supported on most other systems. See
// http://lists.freebsd.org/pipermail/freebsd-bugs/2008-February/028260.html
// for more information on the lack of support for FreeBSD.
if (process.platform !== 'freebsd' && process.platform !== 'android')
dnsopts.hints |= dns.V4MAPPED;
}
debug('connect: find host ' + host); debug('connect: find host ' + host);
debug('connect: dns options', dnsopts); debug('connect: dns options', dnsopts);
self._host = host; self._host = host;

Loading…
Cancel
Save