Browse Source

test: remove obsolete TODO comments

Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.

PR-URL: https://github.com/nodejs/io.js/pull/2032
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
v4.0.0-rc
Rich Trott 10 years ago
parent
commit
bdfeb798ad
  1. 4
      test/parallel/test-fs-read-stream-inherit.js
  2. 4
      test/parallel/test-fs-read-stream.js

4
test/parallel/test-fs-read-stream-inherit.js

@ -2,10 +2,6 @@
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
// TODO Improved this test. test_ca.pem is too small. A proper test would
// great a large utf8 (with multibyte chars) file and stream it in,
// performing sanity checks throughout.
var path = require('path'); var path = require('path');
var fs = require('fs'); var fs = require('fs');
var fn = path.join(common.fixturesDir, 'elipses.txt'); var fn = path.join(common.fixturesDir, 'elipses.txt');

4
test/parallel/test-fs-read-stream.js

@ -2,10 +2,6 @@
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
// TODO Improved this test. test_ca.pem is too small. A proper test would
// great a large utf8 (with multibyte chars) file and stream it in,
// performing sanity checks throughout.
var path = require('path'); var path = require('path');
var fs = require('fs'); var fs = require('fs');
var fn = path.join(common.fixturesDir, 'elipses.txt'); var fn = path.join(common.fixturesDir, 'elipses.txt');

Loading…
Cancel
Save