Browse Source

test: remove simple/test-child-process-fork2

The test assumes the parent and the child are scheduled fairly. Probably true
most of the time but not always, making it fail spuriously.

Bad test, remove it.
v0.9.4-release
Ben Noordhuis 12 years ago
parent
commit
c81dec70e6
  1. 23
      test/fixtures/fork2.js
  2. 73
      test/simple/test-child-process-fork2.js

23
test/fixtures/fork2.js

@ -1,23 +0,0 @@
var assert = require('assert');
var net = require('net');
var connections = 0;
process.on('message', function(m, serverHandle) {
console.log('CHILD got message:', m);
assert.ok(m.hello);
assert.ok(serverHandle);
var server = new net.Server(function(c) {
connections++;
console.log('CHILD got connection');
c.destroy();
process.send({ childConnections: connections });
});
server.listen(serverHandle, /* backlog */ 9, function() {
process.send({ gotHandle: true });
});
});

73
test/simple/test-child-process-fork2.js

@ -1,73 +0,0 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
var assert = require('assert');
var common = require('../common');
var fork = require('child_process').fork;
var net = require('net');
var socketCloses = 0;
var N = 10;
var n = fork(common.fixturesDir + '/fork2.js');
var messageCount = 0;
var server = new net.Server(function(c) {
console.log('PARENT got connection');
c.destroy();
});
server.listen(common.PORT, /* backlog */ 9, function() {
console.log('PARENT send child server handle');
n.send({ hello: 'world' }, server._handle);
});
function makeConnections() {
for (var i = 0; i < N; i++) {
var socket = net.connect(common.PORT, function() {
console.log('CLIENT connected');
});
socket.on('close', function() {
socketCloses++;
console.log('CLIENT closed ' + socketCloses);
if (socketCloses == N) {
n.kill();
server.close();
}
});
}
}
n.on('message', function(m) {
console.log('PARENT got message:', m);
if (m.gotHandle) {
makeConnections();
}
messageCount++;
});
process.on('exit', function() {
assert.equal(10, socketCloses);
assert.ok(messageCount > 1);
});
Loading…
Cancel
Save