Browse Source

deps: fix V8 debugger bugs

This is following-up fix for https://codereview.chromium.org/813873007/.
This bug currently breaks node-inspector client to work.

PR-URL: https://github.com/iojs/io.js/pull/494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v1.8.0-commit
Jay Jaeho Lee 10 years ago
committed by Ben Noordhuis
parent
commit
d566ded26b
  1. 6
      deps/v8/src/debug-debugger.js

6
deps/v8/src/debug-debugger.js

@ -1887,7 +1887,7 @@ DebugCommandProcessor.prototype.resolveFrameFromScopeDescription_ =
// Get the frame for which the scope or scopes are requested. // Get the frame for which the scope or scopes are requested.
// With no frameNumber argument use the currently selected frame. // With no frameNumber argument use the currently selected frame.
if (scope_description && !IS_UNDEFINED(scope_description.frameNumber)) { if (scope_description && !IS_UNDEFINED(scope_description.frameNumber)) {
frame_index = scope_description.frameNumber; var frame_index = scope_description.frameNumber;
if (frame_index < 0 || this.exec_state_.frameCount() <= frame_index) { if (frame_index < 0 || this.exec_state_.frameCount() <= frame_index) {
throw new Error('Invalid frame number'); throw new Error('Invalid frame number');
} }
@ -1972,7 +1972,7 @@ DebugCommandProcessor.resolveValue_ = function(value_description) {
var value_mirror = LookupMirror(value_description.handle); var value_mirror = LookupMirror(value_description.handle);
if (!value_mirror) { if (!value_mirror) {
throw new Error("Failed to resolve value by handle, ' #" + throw new Error("Failed to resolve value by handle, ' #" +
mapping.handle + "# not found"); value_description.handle + "# not found");
} }
return value_mirror.value(); return value_mirror.value();
} else if ("stringDescription" in value_description) { } else if ("stringDescription" in value_description) {
@ -2127,7 +2127,7 @@ DebugCommandProcessor.prototype.lookupRequest_ = function(request, response) {
// Set 'includeSource' option for script lookup. // Set 'includeSource' option for script lookup.
if (!IS_UNDEFINED(request.arguments.includeSource)) { if (!IS_UNDEFINED(request.arguments.includeSource)) {
includeSource = %ToBoolean(request.arguments.includeSource); var includeSource = %ToBoolean(request.arguments.includeSource);
response.setOption('includeSource', includeSource); response.setOption('includeSource', includeSource);
} }

Loading…
Cancel
Save