Browse Source

getaddrinfo returns ENOTFOUND for invalid domain names

change test-http-dns-error to reflect this.
v0.7.4-release
Ryan Dahl 13 years ago
parent
commit
d5a21a29f8
  1. 2
      lib/dns.js
  2. 4
      test/simple/test-http-dns-error.js

2
lib/dns.js

@ -32,7 +32,7 @@ function errnoException(errorno, syscall) {
// For backwards compatibility. libuv returns ENOENT on NXDOMAIN.
if (errorno == 'ENOENT') {
errorno = 'EBADNAME'
errorno = 'ENOTFOUND'
}
e.errno = e.code = errorno;

4
test/simple/test-http-dns-error.js

@ -46,14 +46,14 @@ function test(mod) {
// Ensure that there is time to attach an error listener.
var req = mod.get({host: host, port: 42}, do_not_call);
req.on('error', function(err) {
assert.equal(err.code, 'EBADNAME');
assert.equal(err.code, 'ENOTFOUND');
actual_bad_requests++;
});
// http.get() called req.end() for us
var req = mod.request({method: 'GET', host: host, port: 42}, do_not_call);
req.on('error', function(err) {
assert.equal(err.code, 'EBADNAME');
assert.equal(err.code, 'ENOTFOUND');
actual_bad_requests++;
});
req.end();

Loading…
Cancel
Save