Browse Source

deps: enable node-gyp iojs.lib download checksum

Originally disabled in commit 5de334c ("deps: make node-gyp work again
on windows") due to the then-website lacking the requisite SHASUMS.txt
or SHASUMS256.txt files.  The website has a SHASUMS256.txt now so start
checksumming the download again.

PR-URL: https://github.com/iojs/io.js/pull/918
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
v1.8.0-commit
Ben Noordhuis 10 years ago
committed by cjihrig
parent
commit
da730c76e9
  1. 3
      deps/npm/node_modules/node-gyp/lib/install.js

3
deps/npm/node_modules/node-gyp/lib/install.js

@ -295,8 +295,7 @@ function install (gyp, argv, callback) {
// check content shasums // check content shasums
for (var k in contentShasums) { for (var k in contentShasums) {
log.verbose('validating download checksum for ' + k, '(%s == %s)', contentShasums[k], expectShasums[k]) log.verbose('validating download checksum for ' + k, '(%s == %s)', contentShasums[k], expectShasums[k])
// TODO(piscisaureus) re-enable checksum verification when the correct files are in place. if (contentShasums[k] !== expectShasums[k]) {
if (false || contentShasums[k] !== expectShasums[k]) {
cb(new Error(k + ' local checksum ' + contentShasums[k] + ' not match remote ' + expectShasums[k])) cb(new Error(k + ' local checksum ' + contentShasums[k] + ' not match remote ' + expectShasums[k]))
return return
} }

Loading…
Cancel
Save