Browse Source

test: refactor test-preload

* assert.equal() -> assert.strictEqual()
* replace template string with a string; no variable substitution or
  concatenation or anything like that

PR-URL: https://github.com/nodejs/node/pull/9803
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
v6.x
Rich Trott 8 years ago
committed by Anna Henningsen
parent
commit
e2e51c52c9
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 22
      test/parallel/test-preload.js

22
test/parallel/test-preload.js

@ -37,7 +37,7 @@ childProcess.exec(nodeBinary + ' '
+ fixtureB, + fixtureB,
function(err, stdout, stderr) { function(err, stdout, stderr) {
if (err) throw err; if (err) throw err;
assert.equal(stdout, 'A\nB\n'); assert.strictEqual(stdout, 'A\nB\n');
}); });
// test preloading multiple modules works // test preloading multiple modules works
@ -46,7 +46,7 @@ childProcess.exec(nodeBinary + ' '
+ fixtureC, + fixtureC,
function(err, stdout, stderr) { function(err, stdout, stderr) {
if (err) throw err; if (err) throw err;
assert.equal(stdout, 'A\nB\nC\n'); assert.strictEqual(stdout, 'A\nB\nC\n');
}); });
// test that preloading a throwing module aborts // test that preloading a throwing module aborts
@ -55,7 +55,7 @@ childProcess.exec(nodeBinary + ' '
+ fixtureB, + fixtureB,
function(err, stdout, stderr) { function(err, stdout, stderr) {
if (err) { if (err) {
assert.equal(stdout, 'A\n'); assert.strictEqual(stdout, 'A\n');
} else { } else {
throw new Error('Preload should have failed'); throw new Error('Preload should have failed');
} }
@ -67,7 +67,7 @@ childProcess.exec(nodeBinary + ' '
+ '-e "console.log(\'hello\');"', + '-e "console.log(\'hello\');"',
function(err, stdout, stderr) { function(err, stdout, stderr) {
if (err) throw err; if (err) throw err;
assert.equal(stdout, 'A\nhello\n'); assert.strictEqual(stdout, 'A\nhello\n');
}); });
// test that preload can be used with stdin // test that preload can be used with stdin
@ -76,14 +76,14 @@ const stdinProc = childProcess.spawn(
['--require', fixtureA], ['--require', fixtureA],
{stdio: 'pipe'} {stdio: 'pipe'}
); );
stdinProc.stdin.end('console.log(\'hello\');'); stdinProc.stdin.end("console.log('hello');");
var stdinStdout = ''; var stdinStdout = '';
stdinProc.stdout.on('data', function(d) { stdinProc.stdout.on('data', function(d) {
stdinStdout += d; stdinStdout += d;
}); });
stdinProc.on('close', function(code) { stdinProc.on('close', function(code) {
assert.equal(code, 0); assert.strictEqual(code, 0);
assert.equal(stdinStdout, 'A\nhello\n'); assert.strictEqual(stdinStdout, 'A\nhello\n');
}); });
// test that preload can be used with repl // test that preload can be used with repl
@ -98,12 +98,12 @@ replProc.stdout.on('data', function(d) {
replStdout += d; replStdout += d;
}); });
replProc.on('close', function(code) { replProc.on('close', function(code) {
assert.equal(code, 0); assert.strictEqual(code, 0);
const output = [ const output = [
'A', 'A',
'> ' '> '
].join('\n'); ].join('\n');
assert.equal(replStdout, output); assert.strictEqual(replStdout, output);
}); });
// test that preload placement at other points in the cmdline // test that preload placement at other points in the cmdline
@ -114,7 +114,7 @@ childProcess.exec(nodeBinary + ' '
+ preloadOption([fixtureA, fixtureB]), + preloadOption([fixtureA, fixtureB]),
function(err, stdout, stderr) { function(err, stdout, stderr) {
if (err) throw err; if (err) throw err;
assert.equal(stdout, 'A\nB\nhello\n'); assert.strictEqual(stdout, 'A\nB\nhello\n');
}); });
// test that preload works with -i // test that preload works with -i
@ -123,7 +123,7 @@ const interactive = childProcess.exec(nodeBinary + ' '
+ '-i', + '-i',
common.mustCall(function(err, stdout, stderr) { common.mustCall(function(err, stdout, stderr) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(stdout, `> 'test'\n> `); assert.strictEqual(stdout, "> 'test'\n> ");
})); }));
interactive.stdin.write('a\n'); interactive.stdin.write('a\n');

Loading…
Cancel
Save