Browse Source

src: remove obsolete NOLINT comments

Obsoleted by the recent cpplint upgrade.

PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
v7.x
Ben Noordhuis 9 years ago
parent
commit
f8d3f6fbf4
  1. 4
      src/node_buffer.cc
  2. 2
      src/stream_base.h
  3. 2
      src/string_search.h

4
src/node_buffer.cc

@ -1248,9 +1248,7 @@ void Swap64(const FunctionCallbackInfo<Value>& args) {
std::swap(ts_obj_data[i], ts_obj_data[i + 7]); std::swap(ts_obj_data[i], ts_obj_data[i + 7]);
std::swap(ts_obj_data[i + 1], ts_obj_data[i + 6]); std::swap(ts_obj_data[i + 1], ts_obj_data[i + 6]);
std::swap(ts_obj_data[i + 2], ts_obj_data[i + 5]); std::swap(ts_obj_data[i + 2], ts_obj_data[i + 5]);
// NOLINT added because current cpplint.py is old and doesn't know that std::swap(ts_obj_data[i + 3], ts_obj_data[i + 4]);
// std::swap() now lives in <utility> instead of <algorithm>.
std::swap(ts_obj_data[i + 3], ts_obj_data[i + 4]); // NOLINT
} }
} }

2
src/stream_base.h

@ -261,7 +261,7 @@ class StreamBase : public StreamResource {
const v8::PropertyCallbackInfo<v8::Value>& args); const v8::PropertyCallbackInfo<v8::Value>& args);
template <class Base, template <class Base,
int (StreamBase::*Method)( // NOLINT(whitespace/parens) int (StreamBase::*Method)(
const v8::FunctionCallbackInfo<v8::Value>& args)> const v8::FunctionCallbackInfo<v8::Value>& args)>
static void JSMethod(const v8::FunctionCallbackInfo<v8::Value>& args); static void JSMethod(const v8::FunctionCallbackInfo<v8::Value>& args);

2
src/string_search.h

@ -134,7 +134,7 @@ class StringSearch : private StringSearchBase {
} }
private: private:
typedef size_t (*SearchFunction)( // NOLINT - it's not a cast! typedef size_t (*SearchFunction)(
StringSearch<Char>*, StringSearch<Char>*,
Vector<const Char>, Vector<const Char>,
size_t); size_t);

Loading…
Cancel
Save