lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Alex McKenzie	585c1199a2	test: replaced fixturesDir with fixtures module This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: https://github.com/nodejs/node/pull/15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Colin Leong	d00bb87cc7	test: replace string concatenation with templates PR-URL: https://github.com/nodejs/node/pull/15903 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>	7 years ago
Emily Platzer	47d80384f9	test: updated error message PR-URL: https://github.com/nodejs/node/pull/15906 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
jmcgui05	b2e46c5b54	test: assert.strictEqual using template literals PR-URL: https://github.com/nodejs/node/pull/15944 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Ben Michel	17857d4fc9	test: use common.fixtures in tls test PR-URL: https://github.com/nodejs/node/pull/15965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Sushil Tailor	3953164e42	test: replace error msg w/ template literal PR-URL: https://github.com/nodejs/node/pull/15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Daniele Lisi	0662ebeef9	test: add NODE_UNIQUE_ID value to err message PR-URL: https://github.com/nodejs/node/pull/15914 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Rob Paton	66a990b5ed	test: replace string concatenation with template PR-URL: https://github.com/nodejs/node/pull/15915 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
nodexpertsdev	d4fbffded4	test: change concatenation to template literal PR-URL: https://github.com/nodejs/node/pull/15916 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Gene Wu	c80d9d6a93	test: improve asset msg in test Add result to part of assert message. PR-URL: https://github.com/nodejs/node/pull/15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
penDerGraft	261ae7f58a	test: replace fixturesDir with fixtures module PR-URL: https://github.com/nodejs/node/pull/15919 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Justin Lee	721f6df705	test: remove message from asserts PR-URL: https://github.com/nodejs/node/pull/15920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Pavel Pomerantsev	0fbe0a02df	test: improve an error message PR-URL: https://github.com/nodejs/node/pull/15921 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Uttam Pawar	b8b248a9b3	test: added string_decoder.js a parallel test PR-URL: https://github.com/nodejs/node/pull/15923 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Joe Grace	c4178abc64	test: use fixtures module instead of common PR-URL: https://github.com/nodejs/node/pull/15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Charlie Duong	56c0e7d10f	test: replace fixtureDir with fixtures module This commit replaces the usage of common.fixturesDir with fixtures.path. PR-URL: https://github.com/nodejs/node/pull/15823 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	7 years ago
Alex McKenzie	0e1a9fafdd	test: replaced fixturesDir with fixtures module This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module. PR-URL: https://github.com/nodejs/node/pull/15881 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>	7 years ago
Christopher Choi	b5e8ae4ff8	test: use common.fixtures module Replace common.fixturesDir with usage of the common.fixtures module. PR-URL: https://github.com/nodejs/node/pull/15891 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Paul Milham	7a8d51c079	test: replaced literals in errors with templates PR-URL: https://github.com/nodejs/node/pull/15911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Russell Dempsey	beb23570dc	test: display better error message for assertion This commit makes understanding assertion failures easier by displaying the values that failed the assertion. PR-URL: https://github.com/nodejs/node/pull/15883 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	7 years ago
heeeunkimmm	3f95a8a69e	test: changed buffer-zero output Added interpolated strings to display the error value PR-URL: https://github.com/nodejs/node/pull/15926 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Alex McKenzie	8baa325185	test: replaced fixturesDir with fixtures module PR-URL: https://github.com/nodejs/node/pull/15927 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Faisal Yaqoob	ba6049f7f9	test: remove literal error messages Assertions will now print the values that caused the assertions to fail. PR-URL: https://github.com/nodejs/node/pull/15928 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Daniel Kostro	96221c2471	test: refactor test to use the fixtures module PR-URL: https://github.com/nodejs/node/pull/15934 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com>	7 years ago
Greg Matthews	2bf182dc46	test: replace fixturesDir with fixtures module PR-URL: https://github.com/nodejs/node/pull/15932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Alice Tsui	f96745a4d3	test: modify test messages to template literals PR-URL: https://github.com/nodejs/node/pull/15931 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
BradLarson	3f5f847ed1	test: replace common.fixturesDir with fixture PR-URL: https://github.com/nodejs/node/pull/15940 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	7 years ago
joanne-jjb	31ab2ebbde	test: changes to use template literal PR-URL: https://github.com/nodejs/node/pull/15937 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Mujtaba Al-Tameemi	3a265556ec	test: replace fixturesDir with fixtures PR-URL: https://github.com/nodejs/node/pull/15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Luis Del Águila	fcb0079c5f	test: remove common.fixturesDir Replace `common.fixturesDir` with usage of the `common.fixtures` module PR-URL: https://github.com/nodejs/node/pull/15950 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	7 years ago
Emily Ford	e6e58fde8b	test: remove template literal PR-URL: https://github.com/nodejs/node/pull/15953 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
dpaulino	582749e338	test: removed string from assert message arg PR-URL: https://github.com/nodejs/node/pull/15954 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Brant Barger	b08ae3a8e4	test: replace literal with template string PR-URL: https://github.com/nodejs/node/pull/15957 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
jacjam	ca4e549410	test: upgrade from fixturesDir to fixtures.path The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. PR-URL: https://github.com/nodejs/node/pull/15960 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Chris Budy	ab3c84fc25	test: use defaultHistoryPath instead of path.join PR-URL: https://github.com/nodejs/node/pull/15969 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
BinarySo1o	37681b5e09	test: replace fixturesDir with fixtures module PR-URL: https://github.com/nodejs/node/pull/15961 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	7 years ago
jopann	0dbff4c862	test: replaced fixturesDir with common.fixtures PR-URL: https://github.com/nodejs/node/pull/15971 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	7 years ago
Eric Pemberton	55bb9c4128	test: improve assert messages PR-URL: https://github.com/nodejs/node/pull/15972 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Barry Tam	96eba098ef	test: replacing assert message with template PR-URL: https://github.com/nodejs/node/pull/15974 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Laura Cabrera	0d38e6d01f	test: use common.fixtures module in test-preload PR-URL: https://github.com/nodejs/node/pull/15975 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	7 years ago
Alec Ferguson	91724cb2a1	test: more informative test failure messages PR-URL: https://github.com/nodejs/node/pull/15977 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>	7 years ago
Luke Greenleaf	99237cf00d	test: alter assert.strictEqual to default message PR-URL: https://github.com/nodejs/node/pull/15978 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Anna Henningsen	037d9085f1	src: use more appropriate context-entered check Make the context check in `MakeCallback` match what the comment says (and what actually makes sense). PR-URL: https://github.com/nodejs/node/pull/15691 Fixes: https://github.com/nodejs/node/issues/15672 Ref: https://github.com/nodejs/node/pull/15428 Ref: `f27b5e4bda` Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Sean Cox	b050c14d91	test: replaced common.fixturesDir with readKey PR-URL: https://github.com/nodejs/node/pull/15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	7 years ago
Annie Weng	4457f4feb9	test: replace fixturesDir in tls-env-bad-extra-ca PR-URL: https://github.com/nodejs/node/pull/15813 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	7 years ago
Emily Marigold Klassen	41b65b9fa3	test: use common.fixtures in checkServerIdentity PR-URL: https://github.com/nodejs/node/pull/15951 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>	7 years ago
rhalldearn	b3a8bf3dca	test: replaced common.fixturesDir with readKey PR-URL: https://github.com/nodejs/node/pull/15952 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	7 years ago
John Miller	b13e660a47	test: use fixtures.path for cmd string building PR-URL: https://github.com/nodejs/node/pull/15982 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	7 years ago
Thomas Schorn	59e6791fe5	test: replace fixturesDir with fixtures.readKey PR-URL: https://github.com/nodejs/node/pull/15948 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	7 years ago
ashleyraymaceli	86d803b385	test: replace common.fixturesDir with readKey PR-URL: https://github.com/nodejs/node/pull/15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>	7 years ago

... 2 3 4 5 6 ...

6671 Commits (master)