Ben Noordhuis
91a0e52c03
src: IsInt64() should return bool, not int
11 years ago
Ben Noordhuis
ed806385bf
fs: uids and gids must be unsigned ints
Before this commit, fs.chown() and fs.fchown() coerced the uid and gid
arguments to signed integers which is wrong because uid_t and gid_t are
unsigned on most all platforms and IDs that don't fit in a signed
integer do exist.
This commit changes the aforementioned functions to take unsigned ints
instead. No test because we can't assume the system has [GU]IDs that
large.
This change depends on joyent/libuv@d779eb5.
Fixes #5890 .
12 years ago
Ben Noordhuis
3dbbfd7803
src: remove unused symbols in node_file.cc
12 years ago
Ben Noordhuis
51f6e6a9b3
src, test: downgrade to v8 3.14 api
12 years ago
Ben Noordhuis
7788a6bf85
src: pass node_isolate to Undefined()
12 years ago
Ben Noordhuis
c7d7ae1fe2
src: pass node_isolate to Null()
12 years ago
Ben Noordhuis
01c3d0aa88
src: pass node_isolate to Local<>::New
12 years ago
Ben Noordhuis
6573fc3502
src: pass node_isolate to Integer::New
12 years ago
Ben Noordhuis
910e24b53d
fs: remove fs.sendfile()
Said function has been broken (and useless) since v0.6.0. Remove it altogether.
Fixes #3854 .
12 years ago
Ben Noordhuis
ec03c47c19
fs: fix stat() reporting for large files
Use Number::New(), not Integer::New(). Large values won't fit in an Integer.
Apply to the size, ino and blocks fields.
12 years ago
Ben Noordhuis
07804c7c9a
fs: don't segfault on deeply recursive stat()
Check that the calls to Integer::New() and Date::New() succeed and bail out if
they don't.
V8 returns an empty handle on stack overflow. Trying to set the empty handle as
a property on an object results in a NULL pointer dereference in release builds
and an assert in debug builds.
Fixes #4015 .
13 years ago
isaacs
168a555780
fs: fix naming of truncate/ftruncate functions
For backwards compatibility, fs.truncate(<number>) will proxy to
fs.ftruncate.
Fix #3805
13 years ago
Ben Noordhuis
f0ce98441f
fs: make fs.watchFile() work on windows
13 years ago
Ben Noordhuis
09150b0616
node: replace NODE_STAT_STRUCT with uv_statbuf_t
13 years ago
Ben Noordhuis
eef57dddf4
core: use proper #include directives
13 years ago
Igor Zinkovsky
b4ed3c1969
remove NODE_USE_64BIT_UV_FS_API
13 years ago
Igor Zinkovsky
39e25528eb
windows: enable creating directory junctions with fs.symlink
13 years ago
Igor Zinkovsky
6f82b9f482
64bit offsets for fs calls
13 years ago
isaacs
a26bee8fa1
MakeCallback: Consistent symbol usage
13 years ago
isaacs
91701c2db1
MakeCallback: Use in node_file.cc
13 years ago
Igor Zinkovsky
052aaa4c4d
windows: use 64bit offsets for uv_fs apis
13 years ago
Ben Noordhuis
17524432ff
Fix Engrish in error messages.
13 years ago
ssuda
249c3c165a
Avoiding unnecessary ToString() calls
String::Utf8Value and String::AsciiValue constructors take Handle<Value>
So no need to convert to Handle<String>
13 years ago
Bert Belder
3733a85d8d
Windows: include syscall in fs errors
13 years ago
isaacs
4053c01b53
First arg to fs.fchown is an int, not a string
Bug introduced by 26bfb6bea4
Fix isaacs/npm#2225
13 years ago
Ben Noordhuis
74a8215a86
Revert support for isolates.
It was decided that the performance benefits that isolates offer (faster spin-up
times for worker processes, faster inter-worker communication, possibly a lower
memory footprint) are not actual bottlenecks for most people and do not outweigh
the potential stability issues and intrusive changes to the code base that
first-class support for isolates requires.
Hence, this commit backs out all isolates-related changes.
Good bye, isolates. We hardly knew ye.
13 years ago
Tj Holowaychuk
26bfb6bea4
more specific fs error messages
13 years ago
Ben Noordhuis
4e5247772d
fs, handle_wrap: use Loop(), not uv_default_loop()
Using the default loop will fail in unexpected and interesting ways when
isolates are used.
13 years ago
Shigeki Ohtsu
2156e5eca1
fs: don't assert on uv_fs_*() errors
Pass errors to the JS callbacks, don't assert in C++ land.
Fixes among other things the case where Node aborts because uv_fs_futimes()
returns ENOSYS.
13 years ago
Ryan Dahl
20ba454ef9
Add node::Loop() and don't inc node_isolate.h in *.cc
node::Loop() replaces the NODE_LOOP macro. This avoids hitting
v8::Isolate::GetCurrent() for each loop lookup when HAVE_ISOLATE==0
13 years ago
Ryan Dahl
f168f7d702
Remove node_isolate.h from node.h
13 years ago
Ryan Dahl
a0f3eb015a
node_file.cc should use NODE_LOOP()
13 years ago
Ryan Dahl
9d792f3183
Add node::Loop() and don't inc node_isolate.h in *.cc
node::Loop() replaces the NODE_LOOP macro. This avoids hitting
v8::Isolate::GetCurrent() for each loop lookup when HAVE_ISOLATE==0
13 years ago
Ryan Dahl
87bb848268
Remove node_isolate.h from node.h
13 years ago
Ryan Dahl
a8506c41c6
node_file.cc should use NODE_LOOP()
13 years ago
Igor Zinkovsky
500c8f45f5
Remove platform files, and use uv platform api
13 years ago
Ben Noordhuis
e90db17392
fs: fix typo in error message
13 years ago
Ryan Dahl
e53e9c72cb
move global vars for node_file.cc, node_zlib.cc, and node_crypto.cc
13 years ago
Bert Belder
823a443321
Rename FSError to UVException and move to node.cc
13 years ago
Ben Noordhuis
9b4e8e0a0d
fs: fix typo in function names
The build was not affected: the typos were in macros that only come into effect
when _LARGEFILE_SOURCE is not defined - which is never.
13 years ago
Bert Belder
5b014e0725
Fs: use strncmp instead of memcmp for comparing strings
13 years ago
Author: Igor Zinkovsky
1f16a7b6e5
Enable long paths on windows
13 years ago
Ben Noordhuis
cdcb1118c8
Remove stray NODE_MODULE() semi-colons.
13 years ago
Igor Zinkovsky
6cb15403d3
remove SetCloseOnExec
14 years ago
Ryan Dahl
a6ef3eb271
Upgrade libuv to 4197fc7
and use return value from sync uv_fs functions
14 years ago
Igor Zinkovsky
65e6ba9cce
Enable link, symlink, and readlink on windows
14 years ago
Ben Noordhuis
56efe9cbc5
file: translate libuv error codes to errno names
Fixes incorrect error names (ex. ENOEXEC instead of EBADF,
EMLINK instead of ENOENT).
Fixes #1656 .
14 years ago
Ben Noordhuis
2d9ab49239
file: fix errno propagation in sync fs calls
Include libuv fs error code in the JS exception.
Fixes #1657 .
14 years ago
isaacs
ef523e5719
fix test-fs-realpath
14 years ago
Ryan Dahl
fcfec075e3
internal fs functions called with this == ReqWrap
14 years ago