lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Alfred Cepeda	d9a6d4afe7	test: remove call to `net.Socket.resume()` In test parallel/child-process-fork-net2 `net.Socket.resume()` is not necessary since `net.Socket.pause()` is never called. PR-URL: https://github.com/nodejs/node/pull/8679 Refs: https://github.com/nodejs/node/issues/4640 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>	8 years ago
Sakthipriyan Vairamani	612307564b	test: make import common as the first line The `test/common` module has the capability to identify if any variable is leaked to the global scope and fail the test. So that has to be imported at the beginning. PR-URL: https://github.com/nodejs/node/pull/7786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	8 years ago
Brian White	2bc7841d0f	test: use random ports where possible This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago
Rich Trott	0351b2f1b4	test: refactor switch `test-child-process-fork-net2.js` has a switch statement with 6 cases. Each case uses `child.send()`, passing an object for the callback. `child.send()` ignores the callback because it is not a function. Removing the unused argument. PR-URL: https://github.com/nodejs/node/pull/4870 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>	9 years ago
Michaël Zasso	d1aabd6264	test: fix style issues after eslint update Replace var keyword with const or let. PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By: Roman Reiss <me@silverwind.io>	9 years ago
Rich Trott	9a6cfcef33	test: remove time check test-child-process-fork-net2.js checks that things happen within certain time constraints, thus doubling as a benchmark test in addition to a functionality test. This change removes the time check, as it was causing the test to fail on SmartOS and Windows (and possibly elsewhere) when the tests were run in parallel on CI. There is no guarantee that other tests won't consume enough resources to slow this test down, so don't check the time constraints (beyond the generous timeout that the test is given by test.py in the first place, of course). If we want to do benchmark/performance tests, we should keep them separate from pure functionality tests. The time check may have been a remnant of the distant past when Node.js was much slower. It predates io.js Ref: https://github.com/nodejs/node/pull/4476 PR-URL: https://github.com/nodejs/node/pull/4494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	9 years ago
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Rod Vagg	f9b226c1c1	test: extend timeouts for ARMv6 Based on tests running on original Raspberry Pi PR-URL: https://github.com/iojs/io.js/pull/1554 Reviewed-By: Roman Reiss <me@silverwind.io>	10 years ago
Roman Reiss	7049d7b474	test: increase timeouts on ARM This commit introduces platform-specific test timeouts for the ARM architectures. ARMv6 is notoriously slow so gets very large timeouts on both the timeout value for each test, as well as certain problematic individual tests. ARMv7 and ARMv8 also get slightly increased headroom. PR-URL: https://github.com/iojs/io.js/pull/1366 Fixes: https://github.com/iojs/io.js/issues/1343 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
isaacs	3e1b1dd4a9	Remove excessive copyright/license boilerplate The copyright and license notice is already in the LICENSE file. There is no justifiable reason to also require that it be included in every file, since the individual files are not individually distributed except as part of the entire package.	10 years ago
Fedor Indutny	0e19476595	test: split test in parallel/sequential Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/iojs/io.js/pull/172 Fix: iojs/io.js#139	10 years ago
Alexis Campailla	0da4e0e843	child_process: don't crash process on internal ops 1. Swallow errors when sending internal NODE_HANDLE_ACK messages, so they don't crash the process. 2. Queue process.disconnect() if there are any pending queued messages. Fixes test-child-process-fork-net2.js on win.	11 years ago
Fedor Indutny	4488a69fac	child_process: do not keep list of sent sockets Keeping list of all sockets that were sent to child process causes memory leak and thus unacceptable (see #4587). However `server.close()` should still work properly. This commit introduces two options: * child.send(socket, { track: true }) - will send socket and track its status. You should use it when you want to receive `close` event on sent sockets. * child.send(socket) - will send socket without tracking it status. This performs much better, because of smaller number of RTT between master and child. With both of these options `server.close()` will wait for all sent sockets to get closed.	12 years ago
Fedor Indutny	44cd121c63	Revert "child_process: do not keep list of sent sockets" This reverts commit `db5ee0b3de`.	12 years ago
Fedor Indutny	db5ee0b3de	child_process: do not keep list of sent sockets Keeping list of all sockets that were sent to child process causes memory leak and thus unacceptable (see #4587). However `server.close()` should still work properly. This commit introduces two options: * child.send(socket, { track: true }) - will send socket and track its status. You should use it when you want `server.connections` to be a reliable number, and receive `close` event on sent sockets. * child.send(socket) - will send socket without tracking it status. This performs much better, because of smaller number of RTT between master and child. With both of these options `server.close()` will wait for all sent sockets to get closed.	12 years ago
isaacs	695abba5ac	test: Fix many tests for streams2 net refactor	12 years ago
Andreas Madsen	dceebbfa31	child_process: allow sending a net Socket and Server object using child.send child_process.fork() support sending native hander object, this patch add support for sending net.Server and net.Socket object by converting the object to a native handle object and back to a useful object again. Note when sending a Socket there was emitted by a net Server object, the server.connections property becomes null, because it is no longer possible to known when it is destroyed.	13 years ago