lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
isaacs	b0f6789a78	stream: Remove bufferSize option Now that highWaterMark increases when there are large reads, this greatly reduces the number of calls necessary to _read(size), assuming that _read actually respects the size argument.	12 years ago
isaacs	426b4c6258	stream: _write takes an encoding argument This vastly reduces the overhead of decodeStrings:false streams, such as net and http.	12 years ago
isaacs	cd68d86c32	stream: Remove output function from _transform Just use stream.push(outputChunk) instead.	12 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	e03bc472f0	stream: Start out in sync=true state The Readable and Writable classes will nextTick certain things if in sync mode. The sync flag gets unset after a call to _read or _write. However, most of these behaviors should also be deferred until nextTick if no reads have been made (for example, the automatic '_read up to hwm' behavior on Readable.push(chunk)) Set the sync flag to true in the constructor, so that it will not trigger an immediate 'readable' event, call to _read, before the user has had a chance to set a _read method implementation.	12 years ago
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	12 years ago
isaacs	e26622bd18	stream: Correct Transform class backpressure The refactor in `b43e544140` to use stream.push() in Transform inadvertently caused it to immediately consume all the written data, regardless of whether or not the readable side was being consumed. Only pull data through the _transform() process when the readable side is being consumed. Fix #4667	12 years ago
isaacs	b43e544140	stream: Use push() for Transform._output() This also slightly changes the semantics, in that a 'readable' event may be triggered by the first write() call, even if a user has not yet called read(). This happens because the Transform _write() handler is calling read(0) to start the flow of data. Technically, the new behavior is more 'correct', since it is more in line with the semantics of the 'readable' event in other streams.	12 years ago
isaacs	b15e19a232	streams2: Remove function.bind() usage It's too slow, unfortunately.	12 years ago
isaacs	f20fd22abd	streams2: Add high water mark for Readable Also, organize the numeric settings a bit on the ReadableState class	12 years ago
isaacs	545f512619	streams2: ctor guards on Stream classes	12 years ago
isaacs	8acb416ad0	streams2: Handle immediate synthetic transforms properly	12 years ago
isaacs	caa853bb06	transform: Automatically read() on _write when read buffer is empty	12 years ago
isaacs	3b59fd70f4	streams2: Make Transform streams pull-style That is, the transform is triggered by a _read, not by a _write. This way, backpressure works properly.	12 years ago
isaacs	420e07c577	streams2: The new stream base classes	12 years ago