lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	3f65916fa9	buffer: optimize Buffer.prototype.toString('hex') Move the implementation to C++ land. The old JS implementation used string concatenation, was dog slow and consumed copious amounts of memory for large buffers. Example: var buf = Buffer(0x1000000); // 16 MB buf.toString('hex') // Used 3+ GB of memory. The new implementation operates in O(n) time and space. Fixes #4700.	12 years ago
Ben Noordhuis	2e371b8f92	buffer: fix Buffer::Copy regression from `00b4b7b` If the end argument is omitted or not a number, make it default to the end of the buffer, not zero. Ideally, it should not matter what it defaults to because the JS shim in lib/buffer.js should handle that but there are still several places in node.js core that secrete SlowBuffers, hence Buffer::Copy() gets called without going through Buffer.prototype.copy() first.	12 years ago
Ben Noordhuis	00b4b7bb97	buffer: remove minor Buffer::Copy deoptimizations * Omit ToObject() call. Buffer::Data() and Buffer::Length() know how to deal with Values. * Don't check if the argument is undefined because it realistically never is and undefined->integer coercion achieves the same thing.	12 years ago
Trevor Norris	cbe3941db9	buffer: error and misc cleanup Changed types of errors thrown to be more indicative of what the error represents. Also removed a few unnecessary uses of the v8 fully quantified typename.	12 years ago
Trevor Norris	16bbeccd40	buffer: slow buffer copy compatibility fix Fix issue where SlowBuffers couldn't be passed as target to Buffer copy(). Also included checks to see if Argument parameters are defined before assigning their values. This offered ~3x's performance gain.	12 years ago
Trevor Norris	3d286b68be	buffer: remove float write range checks Removed range checks when writing float values, and removed a few includes and defines. Also updated api docs to reflect that invalid 32 bit float is an unspecified behavior.	12 years ago
isaacs	01a4be4554	buffer: Define INFINITY for MSVC compiler	12 years ago
Ben Noordhuis	498200b87c	buffer: reject negative SlowBuffer offsets Reject negative offsets in SlowBuffer::MakeFastBuffer(), it allows the creation of buffers that point to arbitrary addresses. Reported by Trevor Norris.	12 years ago
Trevor Norris	22b84e6216	buffer: floating point read/write improvements Improvements: * floating point operations are approx 4x's faster * Now write quiet NaN's * all read/write on floating point now done in C, so no more need for lib/buffer_ieee754.js * float values have more accurate min/max value checks * add additional benchmarks for buffers read/write * created benchmark/_bench_timer.js which is a simple library that can be included into any benchmark and provides an intelligent tracker for sync and async tests * add benchmarks for DataView set methods * add checks and tests to make sure offset is greater than 0	12 years ago
Ben Noordhuis	7788a6bf85	src: pass node_isolate to Undefined()	12 years ago
Ben Noordhuis	01c3d0aa88	src: pass node_isolate to Local<>::New	12 years ago
Ben Noordhuis	6573fc3502	src: pass node_isolate to Integer::New	12 years ago
Ben Noordhuis	a329729537	buffer: speed up base64 encoding by 20% Remove a lot of branches from the inner loop. Speeds up buf.toString('base64') by about 20%. Before: $ time out/Release/node benchmark/buffer-base64-encode.js real 0m6.607s user 0m5.508s sys 0m1.088s After: $ time out/Release/node benchmark/buffer-base64-encode.js real 0m5.520s user 0m4.520s sys 0m0.992s	12 years ago
isaacs	6c5356bfe2	Revert "buffer: allocate memory with mmap()" Also Revert "buffer: use MAP_ANON, fix OS X build" This reverts commit `ddb15603e7`. This reverts commit `2433ec8276`.	12 years ago
Ben Noordhuis	ddb15603e7	buffer: use MAP_ANON, fix OS X build	12 years ago
Ben Noordhuis	2433ec8276	buffer: allocate memory with mmap() Work around an issue with the glibc malloc() implementation where memory blocks are never returned to the operating system when they are allocated with brk() and have overlapping lifecycles. Fixes #4283.	12 years ago
Ben Noordhuis	c08e947fbd	buffer: remove unused #includes	12 years ago
Ben Noordhuis	6a128e037e	buffer: report proper retained size in profiler Make buffers report the proper retained size in heap snapshots. Before this commit, Buffer objects would show up in the heap profiler as being only a few hundred bytes large, even if the actual buffer was many megabytes.	12 years ago
Pavel Lang	7ab4a77d6f	buffer: update constructor prototype Change Buffer::New(char, size_t) to Buffer::New(const char, size_t).	12 years ago
Bert Belder	9263213d8e	Avoid compiler warning about negating unsigned value	12 years ago
Ben Noordhuis	eef57dddf4	core: use proper #include directives	13 years ago
isaacs	a26bee8fa1	MakeCallback: Consistent symbol usage	13 years ago
Ben Noordhuis	b82b4f2993	buffer: fix signedness compiler warnings	13 years ago
ssuda	249c3c165a	Avoiding unnecessary ToString() calls String::Utf8Value and String::AsciiValue constructors take Handle<Value> So no need to convert to Handle<String>	13 years ago
Ben Noordhuis	ff4a9d381d	core: use proper #include directives	13 years ago
Ben Noordhuis	8c02f9b7c8	buffer: throw from constructor if length > kMaxLength Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process with the following error message: FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length exceeds max acceptable value Fixes #2280.	13 years ago
Ben Noordhuis	b92a919500	Remove unused variables.	13 years ago
Ben Noordhuis	b9127eb0a5	buffer: support decoding of URL-safe base64	13 years ago
Ben Noordhuis	74a8215a86	Revert support for isolates. It was decided that the performance benefits that isolates offer (faster spin-up times for worker processes, faster inter-worker communication, possibly a lower memory footprint) are not actual bottlenecks for most people and do not outweigh the potential stability issues and intrusive changes to the code base that first-class support for isolates requires. Hence, this commit backs out all isolates-related changes. Good bye, isolates. We hardly knew ye.	13 years ago
Ben Noordhuis	7e40c7ddc9	buffers: fix intermittent out of bounds error The base64 decoder would intermittently throw an out-of-bounds exception when the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the end of the slab. Fixes #2657.	13 years ago
Ben Noordhuis	f101f7c9ba	buffers: honor length argument in base64 decoder Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before this commit, the length argument was ignored. The decoder would keep writing until it hit the end of the buffer. Since most buffers in Node are slices of a parent buffer (the slab), this bug would overwrite the content of adjacent buffers. The bug is trivially demonstrated with the following test case: var assert = require('assert'); var a = Buffer(3); var b = Buffer('xxx'); a.write('aaaaaaaa', 'base64'); assert.equal(b.toString(), 'xxx'); This commit coincidentally also fixes a bug where Buffer._charsWritten was not updated for zero length buffers.	13 years ago
Igor Zinkovsky	500c8f45f5	Remove platform files, and use uv platform api	13 years ago
Ryan Dahl	59055b227a	Move node_buffer.cc globals to struct	13 years ago
Ben Noordhuis	cdcb1118c8	Remove stray NODE_MODULE() semi-colons.	13 years ago
koichik	6a72e52520	buffer: use NO_NULL_TERMINATION flag Refs #394. Fixes #1902.	13 years ago
koichik	3e853e627e	buffer: write() should always set _charsWritten. Refs #1633.	13 years ago
koichik	96ede8cc9b	buffer: Avoid overrun with 'binary' encoding. Fixes #1624.	13 years ago
Ryan Dahl	7d38a3b81c	Fix build - due to V8 API change	13 years ago
Bert Belder	91ecfbcae8	Remove platform_win32_winsock	13 years ago
Ben Noordhuis	2d65f3c59a	Include "platform.h", not <platform.h> - conflicts with system headers Fixes #1003.	13 years ago
Ben Noordhuis	a7bdaabf60	Include "platform.h", not <platform.h> - conflicts with system headers Fixes #1003.	13 years ago
koichik	5208abe723	Fix Buffer drops last null character in UTF-8 Reproduce: $ node > buf = new Buffer('\0') <Buffer > > buf.length 0 > buf = new Buffer(1) <Buffer 28> > buf.write('\0') 0 Fixes #394. Fixes #1210.	14 years ago
Ryan Dahl	5e409c2f1a	makeFastBuffer should not segfault but rather throw on non-buffer	14 years ago
Konstantin Käfer	5e1b7cadb4	Add Buffer::fill method to do memset Fixes #477.	14 years ago
koichik	9533e879f0	Fix Buffer.write() with UCS-2 should not be write partial char closes #916.	14 years ago
Ryan Dahl	8b33a1d8e4	Guard failed buffer constructions. Thanks to Jeremy Barnes for pointing it out.	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
isaacs	0aa1a8a005	Closes GH-695 Add 'hex' encoding to Buffer	14 years ago
Ryan Dahl	0474ce6790	Revert "buffer.toString() shouldn't include null values" This reverts commit `909a5b39d2`. Will fix inside V8's String::New instead.	14 years ago
Ryan Dahl	909a5b39d2	buffer.toString() shouldn't include null values	14 years ago

1 2 3

138 Commits (916aebabb83745dd7b1402a92f120107fa6ea6b6)