PR-URL: https://github.com/nodejs/node/pull/16034
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Replace the common.fixturesDir by fixtures.readKey
in http2 subsystem test 'server startup'.
PR-URL: https://github.com/nodejs/node/pull/15892
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module in the path-makelong test.
PR-URL: https://github.com/nodejs/node/pull/15908
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit replaces the usage of common.fixturesDir with
fixtures.path.
PR-URL: https://github.com/nodejs/node/pull/15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Adding back the changes made by commit# 791d560, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d0, but they are still applicable.
PR-URL: https://github.com/nodejs/node/pull/15829
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15881
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Replace common.fixturesDir with usage of the common.fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit makes understanding assertion failures easier by
displaying the values that failed the assertion.
PR-URL: https://github.com/nodejs/node/pull/15883
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Assertions will now print the values that caused the assertions
to fail.
PR-URL: https://github.com/nodejs/node/pull/15928
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Replace `common.fixturesDir` with usage of the `common.fixtures` module
PR-URL: https://github.com/nodejs/node/pull/15950
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The common/fixtures module provides convenience methods
for working with files in the test/fixtures directory.
PR-URL: https://github.com/nodejs/node/pull/15960
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Updated console example to follow style of rest of the examples
PR-URL: https://github.com/nodejs/node/pull/15962
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Charles T Wall III
Chowdhurian
Maurice Hayward
tabulatedreams
gitHubTracey
ryshep111
Robin Lungwitz
Ivan Etchart
Rafal Leszczynski
Savio Lucena
creisle
Alex McKenzie
Colin Leong
Emily Platzer
jmcgui05
Ben Michel
Sushil Tailor
Daniele Lisi
Rob Paton
nodexpertsdev
Gene Wu
penDerGraft
Justin Lee
Pavel Pomerantsev
Uttam Pawar
Joe Grace
Charlie Duong
suraiyah
Christopher Choi
Paul Milham
Russell Dempsey
heeeunkimmm
Faisal Yaqoob
Daniel Kostro
Greg Matthews
Alice Tsui
BradLarson
joanne-jjb
Govee91
Mujtaba Al-Tameemi
Luis Del Águila
Emily Ford
dpaulino
Sarah Meyer
Brant Barger
jacjam
Chris Budy