lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Ben Noordhuis	686d7b329c	test: build addons with V8_DEPRECATION_WARNINGS=1 PR-URL: https://github.com/nodejs/node/pull/6652 Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago
Rich Trott	e70c88df56	test: remove unused assert module imports Many test modules load assert but do not use it. This change removes those instances. It also removes a handful of other unused variables when they were nearby. PR-URL: https://github.com/nodejs/node/pull/4438 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago
Fedor Indutny	b3cbd13340	buffer: fix assertion error in WeakCallback `CallbackInfo` is now bound to `ArrayBuffer` instance, not `Uint8Array`, therefore `SPREAD_ARG` will abort with: Assertion failed: ((object)->IsUint8Array()) Make changes necessary to migrate it to `ArrayBuffer`. See: https://github.com/nodejs/node/pull/3080#issuecomment-147502167 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/nodejs/node/pull/3329	10 years ago
Rich Trott	2d0fe4c657	test: linting for buffer-free-callback test Test added in `d1f24044` does not pass linting rule added in `3de353b5`. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. PR-URL: https://github.com/nodejs/node/pull/3230 Fixes: https://github.com/nodejs/node/issues/3229 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	10 years ago
Fedor Indutny	660f7591c8	buffer: FreeCallback should be tied to ArrayBuffer FreeCallback should be invoked on the storage disposal (`ArrayBuffer`), not when the view (`Uint8Array` or `Buffer`) is disposed. This causes bug and crashes in addons which create buffers and store only slices of them. PR-URL: https://github.com/nodejs/node/pull/3198 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>	10 years ago