lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	02cab97490	src: more lint after cpplint tightening Commit `847c6d9` adds a 'project headers before system headers' check to cpplint. Update the files in src/ to make the linter pass again.	12 years ago
Trevor Norris	c76ed64348	smalloc: add external to alloc with callbacks Forgot to actually assign cb_info to the External in smalloc::Alloc() that accepts a callback to be run in the weak callback.	12 years ago
Trevor Norris	35e0d60d0c	buffer: slice on zero length buffer SlowBuffer(0) passes NULL instead of doing malloc(0). So when someone attempted to SlowBuffer(0).slice(0, 1) an assert would fail in smalloc::SliceOnto. It's important that the check go where it is because the resulting Buffer needs to have external array data allocated. In the case a user tries to slice a zero length Buffer it will also have NULL passed as the data argument. Also fixed where the .parent attribute was set for zero length Buffers. There is no need to track the source of slice if the slice isn't actually occurring.	12 years ago
Trevor Norris	d817843d2e	smalloc: create separate module It will be confusing if later on we add Buffer#dispose(), and smalloc is its own cpp api anyways. So instead create a new require('smalloc') to expose the previous Buffer.alloc/dispose methods, and expose copyOnto and kMaxLength as well. Other changes: * Added documentation and additional tests. * smalloc::CopyOnto has changed from using assert() to throwing errors on bad argument values because it is not exposed to the user. * Minor style fixes.	12 years ago
Trevor Norris	be940b4501	smalloc: remove NULL assert check In `fa10b75` the assert to check if data == NULL was remove for smalloc::Alloc with no callback. It should have also been removed where a callback is accepted. No sense in making sure that length == 0 if data == NULL because devs already have to be responsible for checking that length is the same as the char* they're passing in.	12 years ago
Ben Noordhuis	636ca7c684	src: cast strong persistent handles to locals Avoids the overhead of creating a new Local every time we unwrap a Persistent handle.	12 years ago
Ben Noordhuis	3220bc4254	smalloc: don't take address of stack var	12 years ago
Trevor Norris	ead8e26b5b	smalloc: call callback if set on AllocDispose Fix bug where if dev passed a callback to Alloc then called AllocDispose it wouldn't bother to pass the data to the callback and instead would just free it.	12 years ago
Trevor Norris	aa8c4a0766	smalloc: zero size allocs may need to be free'd Zero size allocations don't necessarily mean that data == NULL. So instead check each value seperately and perform necessary operations.	12 years ago
Ben Noordhuis	110a9cd8db	lib, src: upgrade after v8 api change This is a big commit that touches just about every file in the src/ directory. The V8 API has changed in significant ways. The most important changes are: * Binding functions take a const v8::FunctionCallbackInfo<T>& argument rather than a const v8::Arguments& argument. * Binding functions return void rather than v8::Handle<v8::Value>. The return value is returned with the args.GetReturnValue().Set() family of functions. * v8::Persistent<T> no longer derives from v8::Handle<T> and no longer allows you to directly dereference the object that the persistent handle points to. This means that the common pattern of caching oft-used JS values in a persistent handle no longer quite works, you first need to reconstruct a v8::Local<T> from the persistent handle with the Local<T>::New(isolate, persistent) factory method. A handful of (internal) convenience classes and functions have been added to make dealing with the new API a little easier. The most visible one is node::Cached<T>, which wraps a v8::Persistent<T> with some template sugar. It can hold arbitrary types but so far it's exclusively used for v8::Strings (which was by far the most commonly cached handle type.)	12 years ago
Trevor Norris	eec43351c4	smalloc: revert change to use pointer indirection Better to compare fixed addresses than to use pointer indirection.	12 years ago
Fedor Indutny	28609d1779	smalloc: fix style, use macro	12 years ago
Trevor Norris	fa10b757f5	smalloc: use malloc instead of new To use realloc the implementation had to be changed to use malloc/free.	12 years ago
Trevor Norris	252cdfa43b	smalloc: add api to manually dispose Persistent If the user knows the allocation is no longer needed then the memory can be manually released. Currently this will not ClearWeak the Persistent, so the callback will still run. If the user passed a ClearWeak callback, and then disposed the object, the buffer callback argument will == NULL.	12 years ago
Trevor Norris	8f3f9f7830	smalloc: initial implementation smalloc is a simple utility for quickly allocating external memory onto js objects. This will be used to centralize how memory is managed in node, and will become the backer for Buffers. So in the future crypto's SlabBuffer, stream's SlabAllocator will be removed. Note on the js API: because no arguments are optional the order of arguments have been placed to match their cc counterparts as closely as possible.	12 years ago

15 Commits (da07709c74b7a695fa2155718a9d9b193ffd169a)