lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
isaacs	c38ce9bc0a	stream: Guarantee ordering of 'finish' event In synchronous Writable streams (where the _write cb is called on the current tick), the 'finish' event (and thus the end() callback) can in some cases be called before all the write() callbacks are called. Use a counter, and have stream.Transform rely on the 'prefinish' event instead of the 'finish' event. This has zero effect on most streams, but it corrects an edge case and makes it perform more deterministically, which is a Good Thing.	12 years ago
isaacs	c93af860a0	stream: call write cb before finish event Since `049903e`, an end callback could be called before a write callback if end() is called before the write is done. This patch resolves the issue. In collaboration with @gne Fixes felixge/node-formidable#209 Fixes #5215	12 years ago
isaacs	c0d500102a	stream: Fix early end in Writables on zero-length writes Doing this causes problems: z.write(Buffer(0)); z.end(); Fix by not ending Writable streams while they're still in the process of writing something.	12 years ago
isaacs	426b4c6258	stream: _write takes an encoding argument This vastly reduces the overhead of decodeStrings:false streams, such as net and http.	12 years ago
isaacs	384f1be739	stream: Writable.end(chunk) after end is an error Calling end(data) calls write(data). Doing this after end should raise a 'write after end' error. However, because end() calls were previously ignored on already ended streams, this error was confusingly suppressed, even though the data never is written, and cannot get to the other side. This is a re-hash of `5222d19a11`, but without assuming that the data passed to end() is valid, and thus breaking a bunch of tests.	12 years ago
Ben Noordhuis	80ea63b958	Revert "stream: Writable.end(chunk) after end is an error" It's breaking ~22 tests, Needs further investigation. This reverts commit `5222d19a11`.	12 years ago
isaacs	5222d19a11	stream: Writable.end(chunk) after end is an error Calling end(data) calls write(data). Doing this after end should raise a 'write after end' error. However, because end() calls were previously ignored on already ended streams, this error was confusingly suppressed, even though the data never is written, and cannot get to the other side.	12 years ago
isaacs	86433979c6	stream: Writables are not pipe()able This handles the fact that stream.Writable inherits from the Stream class, meaning that it has the legacy pipe() method. Override that with a pipe() method that emits an error. Ensure that Duplex streams ARE still pipe()able, however. Since the 'readable' flag on streams is sometimes temporary, it's probably better not to put too much weight on that. But if something is an instanceof Writable, rather than of Readable or Duplex, then it's safe to say that reading from it is the wrong thing to do. Fix #3647	12 years ago
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	12 years ago
isaacs	33b2aebb6d	stream: Writable should ignore encoding for buffers Fix #4727 Fix einaros/ws#159	12 years ago
Nathan Rajlich	a9c4a20331	stream: make Writable#end() accept a callback function This is more backwards-compatible with stream1 streams like `fs.WriteStream` which would allow a callback function to be passed in as the only argument. Closes #4719.	12 years ago
Raynos	444bbd4fa7	streams: Support objects other than Buffers We detect for non-string and non-buffer values in onread and turn the stream into an "objectMode" stream. If we are in "objectMode" mode then howMuchToRead will always return 1, state.length will always have 1 appended to it when there is a new item and fromList always takes the first value from the list. This means that for object streams, the n in read(n) is ignored and read() will always return a single value Fixed a bug with unpipe where the pipe would break because the flowing state was not reset to false. Fixed a bug with sync cb(null, null) in _read which would forget to end the readable stream	12 years ago
isaacs	f8bb031bdc	test: Sync writables may emit finish before callbacks	12 years ago
isaacs	f3e71eb417	test: Writable bufferizing, non-bufferizing, and callbacks	12 years ago
isaacs	9b1b85490b	streams2: Tests of new interfaces	12 years ago