lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Domenic Denicola	7afdba6e0b	vm, core, module: re-do vm to fix known issues As documented in #3042 and in [1], the existing vm implementation has many problems. All of these are solved by @brianmcd's [contextify][2] package. This commit uses contextify as a conceptual base and its code core to overhaul the vm module and fix its many edge cases and caveats. Functionally, this fixes #3042. In particular: - A context is now indistinguishable from the object it is based on (the "sandbox"). A context is simply a sandbox that has been marked by the vm module, via `vm.createContext`, with special internal information that allows scripts to be run inside of it. - Consequently, items added to the context from anywhere are immediately visible to all code that can access that context, both inside and outside the virtual machine. This commit also smooths over the API very slightly: - Parameter defaults are now uniformly triggered via `undefined`, per ES6 semantics and previous discussion at [3]. - Several undocumented and problematic features have been removed, e.g. the conflation of `vm.Script` with `vm` itself, and the fact that `Script` instances also had all static `vm` methods. The API is now exactly as documented (although arguably the existence of the `vm.Script` export is not yet documented, just the `Script` class itself). In terms of implementation, this replaces node_script.cc with node_contextify.cc, which is derived originally from [4] (see [5]) but has since undergone extensive modifications and iterations to expose the most useful C++ API and use the coding conventions and utilities of Node core. The bindings exposed by `process.binding('contextify')` (node_contextify.cc) replace those formerly exposed by `process.binding('evals')` (node_script.cc). They are: - ContextifyScript(code, [filename]), with methods: - runInThisContext() - runInContext(sandbox, [timeout]) - makeContext(sandbox) From this, the vm.js file builds the entire documented vm module API. node.js and module.js were modified to use this new native binding, or the vm module itself where possible. This introduces an extra line or two into the stack traces of module compilation (and thus into most stack traces), explaining the changed tests. The tests were also updated slightly, with all vm-related simple tests consolidated as test/simple/test-vm-* (some of them were formerly test/simple/test-script-*). At the same time they switched from `common.debug` to `console.error` and were updated to use `assert.throws` instead of rolling their own error-testing methods. New tests were also added, of course, demonstrating the new capabilities and fixes. [1]: http://nodejs.org/docs/v0.10.16/api/vm.html#vm_caveats [2]: https://github.com/brianmcd/contextify [3]: https://github.com/joyent/node/issues/5323#issuecomment-20250726 [4]: `bf123f3ef9/src/contextify.cc` [5]: https://gist.github.com/domenic/6068120	12 years ago
Ryan Dahl	9d27faa2c4	Revert "Fix #1801 vm: Use 'sandbox' as global_prototype" Accidentally committed. Revert until review. This reverts commit `200df8641b`.	13 years ago
Ryan Dahl	4e1d6fca8e	Mark tests which are broken in libuv	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Oleg Efimov	093dfaf801	GJSLint all tests, only 3 long lines left in test-url.js test/simple/test-url.js:31:(0110) Line too long (82 characters). test/simple/test-url.js:39:(0110) Line too long (85 characters). test/simple/test-url.js:40:(0110) Line too long (92 characters).	14 years ago
Ryan Dahl	a0159b4b29	Fix global leaks	14 years ago
Joshaven Potter	3d4e4d8909	syntax fixes to pass jslint	14 years ago
Ryan Dahl	9fd5e3c89c	Update tests to work with module contexts	15 years ago
Ryan Dahl	ba792ea202	:%s/sys.puts/console.log/g and there was much rejoicing	15 years ago
isaacs	5861db8a69	Remove process.mixin dependency from all tests.	15 years ago
arlolra	724ccf10df	Tests on common port.	15 years ago
arlolra	04fac19822	Split tests.	15 years ago
Ryan Dahl	764783560e	Remove Promise.prototype.wait() I don't want users to have to think about coroutine safety. http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/2468/focus=2603	15 years ago
Ryan Dahl	b82ef28d9d	Rename 'posix' module to 'fs'	15 years ago
Ryan Dahl	f80cc69c23	libeio bugfix part 3 Finally (hopefully) fix the issue that Felix reported. It's only appearing on macintosh (test/mjsunit/test-eio-race3.js) The trick/hack is to call eio_poll() again before reentering the event loop. Additionally this commit implements a more complex method of calling eio_poll(), occasionally dropping to an ev_idle watcher. See also: `3f39772834` http://lists.schmorp.de/pipermail/libev/2010q1/000855.html http://groups.google.com/group/nodejs/browse_thread/thread/9f8db11c792a68bb/a89705f68971f53c	15 years ago