Domenic Denicola 7afdba6e0b vm, core, module: re-do vm to fix known issues As documented in #3042 and in [1], the existing vm implementation has many problems. All of these are solved by @brianmcd's [contextify][2] package. This commit uses contextify as a conceptual base and its code core to overhaul the vm module and fix its many edge cases and caveats. Functionally, this fixes #3042. In particular: - A context is now indistinguishable from the object it is based on (the "sandbox"). A context is simply a sandbox that has been marked by the vm module, via `vm.createContext`, with special internal information that allows scripts to be run inside of it. - Consequently, items added to the context from anywhere are immediately visible to all code that can access that context, both inside and outside the virtual machine. This commit also smooths over the API very slightly: - Parameter defaults are now uniformly triggered via `undefined`, per ES6 semantics and previous discussion at [3]. - Several undocumented and problematic features have been removed, e.g. the conflation of `vm.Script` with `vm` itself, and the fact that `Script` instances also had all static `vm` methods. The API is now exactly as documented (although arguably the existence of the `vm.Script` export is not yet documented, just the `Script` class itself). In terms of implementation, this replaces node_script.cc with node_contextify.cc, which is derived originally from [4] (see [5]) but has since undergone extensive modifications and iterations to expose the most useful C++ API and use the coding conventions and utilities of Node core. The bindings exposed by `process.binding('contextify')` (node_contextify.cc) replace those formerly exposed by `process.binding('evals')` (node_script.cc). They are: - ContextifyScript(code, [filename]), with methods: - runInThisContext() - runInContext(sandbox, [timeout]) - makeContext(sandbox) From this, the vm.js file builds the entire documented vm module API. node.js and module.js were modified to use this new native binding, or the vm module itself where possible. This introduces an extra line or two into the stack traces of module compilation (and thus into most stack traces), explaining the changed tests. The tests were also updated slightly, with all vm-related simple tests consolidated as test/simple/test-vm-* (some of them were formerly test/simple/test-script-*). At the same time they switched from `common.debug` to `console.error` and were updated to use `assert.throws` instead of rolling their own error-testing methods. New tests were also added, of course, demonstrating the new capabilities and fixes. [1]: http://nodejs.org/docs/v0.10.16/api/vm.html#vm_caveats [2]: https://github.com/brianmcd/contextify [3]: https://github.com/joyent/node/issues/5323#issuecomment-20250726 [4]: `bf123f3ef9/src/contextify.cc` [5]: https://gist.github.com/domenic/6068120		12 years ago
benchmark	fixes #6031 spelling errors	12 years ago
deps	uv: Upgrade to v0.11.8	12 years ago
doc	Merge remote-tracking branch 'ry/v0.10'	12 years ago
lib	vm, core, module: re-do vm to fix known issues	12 years ago
src	vm, core, module: re-do vm to fix known issues	12 years ago
test	vm, core, module: re-do vm to fix known issues	12 years ago
tools	tools: cpplint: fix NOLINT(build/include_order)	12 years ago
.gitattributes	Explicitly disable cr/lf conversion for test fixtures	14 years ago
.gitignore	tools: Add wrk for benchmarking http servers	12 years ago
.mailmap	Update .mailmap and AUTHORS	12 years ago
AUTHORS	2013.08.21, Version 0.11.6 (Unstable)	12 years ago
BSDmakefile	Tell BSD users to run `gmake` instead.	14 years ago
CONTRIBUTING.md	doc: clarify subsystems in CONTRIBUTING.md	12 years ago
ChangeLog	2013.08.21, Version 0.11.6 (Unstable)	12 years ago
LICENSE	Merge remote-tracking branch 'upstream/v0.10'	12 years ago
Makefile	build: make ninja build respect V=	12 years ago
README.md	doc: remove travis status image	12 years ago
android-configure	build: add android support	12 years ago
common.gypi	build: disable some msvc compiler warnings	12 years ago
configure	build: disable SSLv2 by default	12 years ago
node.gyp	vm, core, module: re-do vm to fix known issues	12 years ago
vcbuild.bat	build: vcbuild.bat fix for Visual Studio 2012	12 years ago

README.md

Evented I/O for V8 javascript.

To build:

Prerequisites (Unix only):

* GCC 4.2 or newer
* Python 2.6 or 2.7
* GNU Make 3.81 or newer
* libexecinfo (FreeBSD and OpenBSD only)

Unix/Macintosh:

./configure
make
make install

If your python binary is in a non-standard location or has a non-standard name, run the following instead:

export PYTHON=/path/to/python
$PYTHON ./configure
make
make install

Windows:

vcbuild.bat

To run the tests:

Unix/Macintosh:

make test

Windows:

vcbuild.bat test

To build the documentation:

make doc

To read the documentation:

man doc/node.1

README.md

Evented I/O for V8 javascript.

To build:

To run the tests:

To build the documentation:

To read the documentation:

Resources for Newcomers