lukechilds/node - node - Gitea: Git with a cup of tea

History

Ben Noordhuis c30cc4e3a5 src: don't call DecodeWrite() on Buffers Don't call DecodeWrite() with a Buffer as its argument because it in turn calls StringBytes::Write() and that method expects a Local<String>. "Why then does that function take a Local<Value>?" I hear you ask. Good question but I don't have the answer. I added a CHECK for good measure and what do you know, all of a sudden a large number of crypto tests started failing. Calling DecodeWrite(BINARY) on a buffer is nonsensical anyway: if you want the contents of the buffer, just copy out the data, there is no need to decode it - and that's exactly what this commit does. Fixes a great many instances of the following run-time error in debug builds: FATAL ERROR: v8::String::Cast() Could not convert to string		11 years ago
..
res	windows: add support for '_Total' perf counters	12 years ago
async-wrap-inl.h	async_wrap: add provider types/pass to constructor	11 years ago
async-wrap.h	async_wrap: add provider types/pass to constructor	11 years ago
base-object-inl.h	base-object: add BaseObject	11 years ago
base-object.h	src: add comments about implicit dependencies	11 years ago
cares_wrap.cc	src: update to v8 3.24 APIs	11 years ago
env-inl.h	src: update to v8 3.24 APIs	11 years ago
env.h	src: update to v8 3.24 APIs	11 years ago
fs_event_wrap.cc	src: update to v8 3.24 APIs	11 years ago
handle_wrap.cc	src: update to v8 3.24 APIs	11 years ago
handle_wrap.h	headers: fix spelling error	11 years ago
node.cc	src: update to v8 3.24 APIs	11 years ago
node.d	dtrace: add missing translator	13 years ago
node.h	node: fix exported signatures of MakeCallback	11 years ago
node.js	src: domain should not replace nextTick function	11 years ago
node.stp	systemtap: add tapset for node user probes	12 years ago
node_buffer.cc	src: update to v8 3.24 APIs	11 years ago
node_buffer.h	src: remove `node_isolate` from source	11 years ago
node_constants.cc	crypto: allow custom generator for DiffieHellman	11 years ago
node_constants.h	src: lint c++ code	12 years ago
node_contextify.cc	src: update to v8 3.24 APIs	11 years ago
node_contextify.h	src: Remove unused refs to node_object_wrap.h	11 years ago
node_counters.cc	src: remove `node_isolate` from source	11 years ago
node_counters.h	src: remove `node_isolate` from source	11 years ago
node_crypto.cc	src: don't call DecodeWrite() on Buffers	11 years ago
node_crypto.h	src: update to v8 3.24 APIs	11 years ago
node_crypto_bio.cc	tls: stop NodeBIO::Gets from reading off end of buffer	11 years ago
node_crypto_bio.h	tls_wrap: use writev when possible	11 years ago
node_crypto_clienthello-inl.h	tls: asynchronous SNICallback	12 years ago
node_crypto_clienthello.cc	crypto: fix signed/unsigned comparison warning	12 years ago
node_crypto_clienthello.h	tls: asynchronous SNICallback	12 years ago
node_crypto_groups.h	src: lint c++ code	12 years ago
node_dtrace.cc	src: update to v8 3.24 APIs	11 years ago
node_dtrace.h	src: remove `node_isolate` from source	11 years ago
node_file.cc	src: update to v8 3.24 APIs	11 years ago
node_file.h	src: add multi-context support	12 years ago
node_http_parser.cc	src: update to v8 3.24 APIs	11 years ago
node_http_parser.h	src: lint c++ code	12 years ago
node_internals.h	src: update to v8 3.24 APIs	11 years ago
node_javascript.cc	src: remove `node_isolate` from source	11 years ago
node_javascript.h	src: remove `node_isolate` from source	11 years ago
node_main.cc	core: use proper #include directives	13 years ago
node_object_wrap.h	src, test: fix up ObjectWrap, `make test-addons`	11 years ago
node_os.cc	src: update to v8 3.24 APIs	11 years ago
node_provider.d	dtrace: actually use the _handle.fd value	12 years ago
node_root_certs.h	crypto: update root certificates	11 years ago
node_stat_watcher.cc	src: update to v8 3.24 APIs	11 years ago
node_stat_watcher.h	src: remove `node_isolate` from source	11 years ago
node_v8.cc	src: update to v8 3.24 APIs	11 years ago
node_version.h	Now working on 0.11.13	11 years ago
node_watchdog.cc	src: use new loop API	11 years ago
node_watchdog.h	vm: fix race condition in timeout	11 years ago
node_win32_etw_provider-inl.h	src: lint c++ code	12 years ago
node_win32_etw_provider.cc	src: fix up unused/unordered imports	12 years ago
node_win32_etw_provider.h	src: more lint after cpplint tightening	12 years ago
node_win32_perfctr_provider.cc	build: un-break the windows build	12 years ago
node_win32_perfctr_provider.h	src: lint c++ code	12 years ago
node_wrap.h	src: remove `node_isolate` from source	11 years ago
node_zlib.cc	src: fix segfaults, fix 32 bits integer negation	11 years ago
notrace_macros.py	src: rename macros.py to notrace_macros.py	12 years ago
perfctr_macros.py	windows: add tracing with performance counters	12 years ago
pipe_wrap.cc	src: update to v8 3.24 APIs	11 years ago
pipe_wrap.h	src: don't use class specific Unwrap methods	11 years ago
process_wrap.cc	src: update to v8 3.24 APIs	11 years ago
queue.h	src: make queue.h c++ compatible	11 years ago
req_wrap.h	src: update to v8 3.24 APIs	11 years ago
signal_wrap.cc	src: update to v8 3.24 APIs	11 years ago
smalloc.cc	src: fix up smalloc weak persistent usage	11 years ago
smalloc.h	smalloc: remove `env.h` include	11 years ago
spawn_sync.cc	src: update to v8 3.24 APIs	11 years ago
spawn_sync.h	src: remove `node_isolate` from source	11 years ago
stream_wrap.cc	src: update to v8 3.24 APIs	11 years ago
stream_wrap.h	src: update from uv_read2_start removal	11 years ago
string_bytes.cc	src: don't call DecodeWrite() on Buffers	11 years ago
string_bytes.h	src: remove `node_isolate` from source	11 years ago
tcp_wrap.cc	src: update to v8 3.24 APIs	11 years ago
tcp_wrap.h	src: don't use class specific Unwrap methods	11 years ago
timer_wrap.cc	src: update to v8 3.24 APIs	11 years ago
tls_wrap.cc	src: update to v8 3.24 APIs	11 years ago
tls_wrap.h	crypto: make NewSessionDoneCb public	11 years ago
tree.h	dns: don't rely on libuv for c-ares integration	13 years ago
tty_wrap.cc	src: update to v8 3.24 APIs	11 years ago
tty_wrap.h	src: don't use class specific Unwrap methods	11 years ago
udp_wrap.cc	src: update to v8 3.24 APIs	11 years ago
udp_wrap.h	src: don't use class specific Unwrap methods	11 years ago
util-inl.h	src: shorten Object{Wrap,Unwrap}	11 years ago
util.h	src: add CHECK_{GE,GT,LE,LT} macros	11 years ago
uv.cc	src: update to v8 3.24 APIs	11 years ago
v8abbr.h	dtrace: backport two byte string fix	12 years ago
v8ustack.d	dtrace: backport two byte string fix	12 years ago