3c2ba8c373
Try exactly until the connection timeout has been reached
Fixes #587
9 years ago
a9e7663aff
removing flush_and_error from on_error handler
11 years ago
03e8c03503
Add connection timeout and max attempts tests
9 years ago
0b8705abe9
Do not run all tests with every single connection (if one connection works, the others are going to be fine too)
9 years ago
1e0421ac3b
Emit errors if the connection timeout / maximum retry attempts have been exceeded
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
9 years ago
f2ee8dbc9e
Add a connection timeout of 24h as new default for maximum reconnecting
9 years ago
04c986a4cd
Lowering the first retry_delay and begin from that value
Earlier the first value was never used, as it was first multiplied by 1.7
9 years ago
cd5cfb4a8e
Emit an error when connection permanently goes down
Closes #724 and #615
9 years ago
403bfb0200
Merge pull request #835 from fintura/remove-stuff
Remove send_command safety checks. Fixes #629
9 years ago
eea9d2af76
Merge pull request #847 from fintura/check-password
Check that the password is from type string
9 years ago
30f227b7b1
Merge pull request #846 from fintura/parser
Improve js parser
9 years ago
aab1fc8f4f
Merge pull request #838 from fintura/consistent-commands
Consistent commands arguments. All commands are from now on behaving the same no matter if they are on multi or no and they all take an array as either the first or second argument.
Fixes #686 #369 #422 #390 and Closes #634
9 years ago
005e869d83
Remove send_command safety checks
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that
Fix #629 and insert tests
9 years ago
013831c00f
Improve js parser
9 years ago
c269b7539c
Check that the password is from type string
9 years ago
a0c92b0756
Add a lot more tests to indicate that the everything is consistent
Add a test for #390
More special cases
9 years ago
c522ca1264
Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
9 years ago
e24f056b2d
Merge pull request #841 from fintura/command
Add .command_used to errors returned by the parser.
Fix authentication failure being emitted instead of returned by a callback if present. Fixes #427
9 years ago
ebbb0146b9
Fix auth emitting the error even though a callback is present
Fix auth manipulating the returned error
And this is also removing some dead code
9 years ago
1a06cfb6ec
Add .command_used to errors thrown by the parser
9 years ago
e4bd9bf0c5
Merge pull request #839 from fintura/statements
Small stuff like: let v8 inline instead of doing in manually
9 years ago
6ea70271d6
v8 is going to inline a couple of things that were necessary a few years ago
9 years ago
4bdcf8a598
Fix regression: version detection in tests did not work properly anymore
9 years ago
785af29385
Merge pull request #842 from fintura/speedup
Small speedup: do not call data.toString() on debug messages
9 years ago
4a8da6dce5
Merge pull request #823 from fintura/debug
Refactor debug mode not to break old code and to work with NODE_DEBUG too
9 years ago
4f79370887
Merge pull request #816 from fintura/callback
Remove try callback and emit errors if no callback is present. Fixes #456 , #591 , #522 and #755
9 years ago
4f0443cdd4
Emit errors instead of throwing them
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
9 years ago
c6ae7832a3
Remove try callbacks and emit an error in case of no callback has been provided
9 years ago
1b261fcaad
Revert "added test for multi.hmset's array handling"
This reverts commit bb221adec4#686 and #838 for more details
9 years ago
bf2ccd9580
Merge pull request #837 from NodeRedis/windows-tests
retrofit tests so that they work on Windows
9 years ago
bb221adec4
added test for multi.hmset's array handling
9 years ago
be708906fa
add test for providing auth after client is created
9 years ago
68936c5eb2
based on code-review added back check for error
9 years ago
e6aa3826f7
Small speedup: do not call data.toString() on debug messages
9 years ago
bb1ab1498b
fix badge markdown, address code-review concerns
9 years ago
b717c8154b
added windows badge, made changes based on @BrideAr's code-review
9 years ago
224aff9cee
found another difference on Windows CI
9 years ago
40f535b6c6
trying to find an incantation that actually boots Redis
9 years ago
a3ffc3a125
move redis to the install stanza
9 years ago
d5ccb3965d
add appveyor configuration
9 years ago
71ea42f1bd
fix linting and timeout issue
9 years ago
20bc05abb5
test suite should now run on Windows
9 years ago
0b46a69c7e
fix merge, run linting as part of the test suite
9 years ago
77e8552374
down to one failing test on Windows, time to rebase
9 years ago
65b26ed9aa
remove hiredis from dev-dependencies
9 years ago
a0bf9e2314
tweaks based on running test-suite on Windows on an older Redis
9 years ago
b4da975785
prep for getting tests to work on appveyor
9 years ago
06121a65c4
Increase the coverage
9 years ago
8fa5b93c93
Merge pull request #836 from fintura/fix-errors
Do not wrap errors into other errors.
9 years ago
0925885a88
Do not wrap errors into other errors. The trace is going to be manipulated that way.
9 years ago
Ruben Bridgewater
Chris Hamant
Ruben Bridgewater
Benjamin E. Coe
Benjamin Coe