Browse Source

doc: fix the order of lint and prettier (#10095)

main
Kiho · Cham 8 years ago
committed by Dan Abramov
parent
commit
163b19b4f6
  1. 4
      contributing/how-to-contribute.md

4
contributing/how-to-contribute.md

@ -80,8 +80,8 @@ The core team is monitoring for pull requests. We will review your pull request
2. If you've added code that should be tested, add tests! 2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation. 3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes (`npm test`). 4. Ensure the test suite passes (`npm test`).
5. Make sure your code lints (`npm run lint`). 5. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`). 6. Make sure your code lints (`npm run lint`).
7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`). 7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes. You can see the full output of fiber tests with `REACT_DOM_JEST_USE_FIBER=1 npm test`. 8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes. You can see the full output of fiber tests with `REACT_DOM_JEST_USE_FIBER=1 npm test`.
9. If you haven't already, complete the CLA. 9. If you haven't already, complete the CLA.

Loading…
Cancel
Save