lukechilds
/
react.dev
mirror of https://github.com/lukechilds/react.dev.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Add prettier instructions to PR template and contribution guide

main
Andrew Clark 8 years ago
parent
b5e8ba7d3c
commit
9a22d47427
1 changed files with 4 additions and 3 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 7
      contributing/how-to-contribute.md

7
contributing/how-to-contribute.md
View File

@ -81,9 +81,10 @@ The core team is monitoring for pull requests. We will review your pull request
3. If you've changed APIs, update the documentation. 3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes (`npm test`). 4. Ensure the test suite passes (`npm test`).
5. Make sure your code lints (`npm run lint`). 5. Make sure your code lints (`npm run lint`).
6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`). 6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes. 7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
8. If you haven't already, complete the CLA. 8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
9. If you haven't already, complete the CLA.
### Contributor License Agreement (CLA) ### Contributor License Agreement (CLA)

Write Preview
Loading…
Cancel
Save