Rauno Freiberg
3d50f0deb6
Add contributing guidelines reference to readme ( #753 )
* Add contributing guidelines reference to readme
* Tweak
7 years ago
Brian Vaughn
4a2a8541cb
Merge pull request #738 from koba04/forward-ref-examples
React.forwardRef accepts a render function, not Functional Component
7 years ago
Toru Kobayashi
0ea7d99127
Revert "Adopt bvaughn's example"
This reverts commit 2e1554dc32
.
7 years ago
chucksellick
dbe5b49bbf
Fix a very small typo ( #754 )
"potential" -> "potentially"
7 years ago
Toru Kobayashi
2e1554dc32
Adopt bvaughn's example
7 years ago
Chanyeon Kim
e8cdf5128a
Fix button => themed-buton ( #752 )
7 years ago
Cristian Garabagiu
82a402168d
Fixed broken URL ( #750 )
7 years ago
Asher Michael
c1c9714041
Update context.md ( #751 )
Corrected a grammar error in one of the notes section.
7 years ago
chucksellick
abd3af9a3d
Recommend getDerivedStateFromProps ( #747 )
Fix a couple of paragraphs that recommended UNSAFE_componentWillReceiveProps
where it would now be more correct to recommend getDerivedStateFromProps.
7 years ago
Pat
e61d594b64
Minor: context/theme-detailed-app.js broken ( #746 )
* Minor: context/theme-detailed-app.js broken
Today I tested out the new Context API using using [CRA](https://github.com/facebook/create-react-app ).
I encountered a runtime exception, so this tiny PR is intended to make it easier for future Context API learners.
`ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor`
create-react-app@next commit da518d2238298dd5db74e9c63c12251099f87bb0
* Update theme-detailed-app.js
7 years ago
Brian Vaughn
85f36661f7
Merge pull request #745 from nateq314/patch-1
Fix cDU to correctly make async request
7 years ago
Almero Steyn
a5a622e2c4
a11y-doc: Adjust Focus Control to new 16.3 refs + link fixes. ( #742 )
* a11y-doc: Adjust Focus Control to new 16.3 refs + link fixes.
* Update accessibility.md
7 years ago
Nathan Quarles
51a864d858
Fix cDU to correctly make async request
When a new `id` prop is passed in, `getDerivedStateFromProps` sets `this.state.externalData` to `null`. If I understand the new API correctly the return value of gDSFP() either becomes the new state or is merged into the new state? If so, then `componentDidUpdate` should examine the new state (`this.state.externalData`), not `prevState.externalData`.
7 years ago
Shovon Hasan
62638c8b2d
Fix broken link in UNSFE_componentWillReceiveProps docs. ( #744 )
7 years ago
Dan Abramov
2bd8eda1fc
Update refs-and-the-dom.md
7 years ago
Tatyana Tsvetkova
72fd7ff75a
Update accessibility.md ( #708 )
Fix for broken links to W3C
7 years ago
Christian Maughan Tegnér
b1d705ad60
Use correct component name in context doc example ( #740 )
* Use correct component name in context doc example
I'm assuming the intention was to reference the `FancyButton` component defined directly above, unless I'm misunderstanding how to read this example.
* Prettier
7 years ago
Toru Kobayashi
c72935a054
prettier
7 years ago
Toru Kobayashi
d5c449d824
React.forwardRef accepts a render function, not Functional Component
7 years ago
Alex Krolick
e8646074ee
Absolute link
7 years ago
Dan Abramov
ab436ccea3
Add missing "and"
7 years ago
Brian Vaughn
73ba23fccd
Updated createRef example not to use class property syntax
7 years ago
Brian Vaughn
99d5ce47d3
Replaced hyphen with em dash
7 years ago
Michael Jackson
425043533f
Merge pull request #700 from billyjanitsch/clarify-render-prop
Clarify PureComponent render prop caveat
7 years ago
Brian Vaughn
e86caae7a4
Merge pull request #735 from bvaughn/wording-tweaks
Wording tweaks
7 years ago
Brian Vaughn
221b7be5e9
nit
7 years ago
Brian Vaughn
2a9701805c
Wording tweaks
7 years ago
Brian Vaughn
63e0e91a3e
Merge pull request #734 from bvaughn/update-version
Updated site constants to 16.3
7 years ago
Brian Vaughn
fc9936f4ea
Updated site constants to 16.3
7 years ago
Brian Vaughn
b618684fe2
Merge pull request #587 from bvaughn/16.3-release-blog-post
16.3 release blog draft
7 years ago
Brian Vaughn
aa9810f4fd
Fixed some links and improved a recommendation
7 years ago
Brian Vaughn
ac1d767bd3
Fixed link
7 years ago
Brian Vaughn
5a587d187e
Tweaked link to Context API
7 years ago
Brian Vaughn
992a756306
Missing 'we'
7 years ago
Brian Vaughn
e5ca13e287
Cross-link to async update post
7 years ago
Brian Vaughn
3a36a402a5
Revert "Added inline child function caveat to Context docs"
This reverts commit 691cd4577c
.
7 years ago
Brian Vaughn
797a792b77
Revert "Prettier"
This reverts commit 032576cf7b
.
7 years ago
Brian Vaughn
032576cf7b
Prettier
7 years ago
Brian Vaughn
691cd4577c
Added inline child function caveat to Context docs
7 years ago
Brian Vaughn
28b2b762ab
Tweaked state-and-lifecycle wording more
7 years ago
Brian Vaughn
57eb7cc3f3
Tweaked message about what goes into state
7 years ago
Alex Krolick
eb60d5a887
Merge pull request #714 from wlwl2/patch-1
Update faq-build.md
7 years ago
William Lim (林良)
8c797096e7
Update faq-build.md
7 years ago
Brian Vaughn
a29098e958
Merge branch 'master' into 16.3-release-blog-post
7 years ago
Brian Vaughn
2e76743726
Merge pull request #730 from bvaughn/update-on-async-updates-again-and-again
Update async blog post in response to feedback 🙂
7 years ago
Brian Vaughn
6afbc7b56e
Added side effects props change example
7 years ago
Brian Vaughn
95f2a184d0
Added a note about mirroring props in state and no prevProps on gDSFP
7 years ago
Alex Krolick
3a2ad77032
Merge pull request #722 from chaficnajjar/patch-1
Fix mistake in integrating-with-other-libraries.md
7 years ago
Alex Krolick
672853159a
Merge pull request #723 from chaficnajjar/patch-1
Fix typo in integrating-with-other-libraries.md
7 years ago
Alex Krolick
8006e2dc8e
Merge pull request #688 from raunofreiberg/fix/footer-nav-links-title
fix: NavigationFooter links pull paginated title from nav metadata
7 years ago