Merge branch 'legacy-quote-reserved-properties' into chge-master

src/Declaration.js

@@ -1,5 +1,5 @@
 import { blank, forOwn, keys } from './utils/object.js';
-import makeLegalIdentifier from './utils/makeLegalIdentifier.js';
+import makeLegalIdentifier, { reservedWords } from './utils/makeLegalIdentifier.js';
 import { UNKNOWN } from './ast/values.js';
 
 export default class Declaration {
@@ -86,6 +86,7 @@ export class SyntheticNamespaceDeclaration {
 				name = `'${name}'`;
 			}
 
+			if ( legacy && ~reservedWords.indexOf( name ) ) name = `'${name}'`;
 			return `${indentString}${name}: ${original.getName( es )}`;
 		});
 

src/utils/makeLegalIdentifier.js

@@ -1,6 +1,6 @@
 import { blank } from './object.js';
 
-const reservedWords = 'break case class catch const continue debugger default delete do else export extends finally for function if import in instanceof let new return super switch this throw try typeof var void while with yield enum await implements package protected static interface private public'.split( ' ' );
+export const reservedWords = 'break case class catch const continue debugger default delete do else export extends finally for function if import in instanceof let new return super switch this throw try typeof var void while with yield enum await implements package protected static interface private public'.split( ' ' );
 const builtins = 'Infinity NaN undefined null true false eval uneval isFinite isNaN parseFloat parseInt decodeURI decodeURIComponent encodeURI encodeURIComponent escape unescape Object Function Boolean Symbol Error EvalError InternalError RangeError ReferenceError SyntaxError TypeError URIError Number Math Date String RegExp Array Int8Array Uint8Array Uint8ClampedArray Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array Map Set WeakMap WeakSet SIMD ArrayBuffer DataView JSON Promise Generator GeneratorFunction Reflect Proxy Intl'.split( ' ' );
 
 const blacklisted = blank();

test/form/legacy-reified-namespace/_config.js

@@ -0,0 +1,7 @@
+module.exports = {
+	description: 'quotes reserved words in object literals',
+	options: {
+	moduleName: 'myBundle',
+		legacy: true
+	}
+};

test/form/legacy-reified-namespace/_expected/amd.js

@@ -0,0 +1,14 @@
+define(function () { 'use strict';
+
+	const _typeof = 'typeof';
+	const foo = 1;
+
+
+	var namespace = (Object.freeze || Object)({
+		'typeof': _typeof,
+		foo: foo
+	});
+
+	console.log( namespace );
+
+});

test/form/legacy-reified-namespace/_expected/cjs.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const _typeof = 'typeof';
+const foo = 1;
+
+
+var namespace = (Object.freeze || Object)({
+	'typeof': _typeof,
+	foo: foo
+});
+
+console.log( namespace );

test/form/legacy-reified-namespace/_expected/es.js

@@ -0,0 +1,10 @@
+const _typeof = 'typeof';
+const foo = 1;
+
+
+var namespace = (Object.freeze || Object)({
+	'typeof': _typeof,
+	foo: foo
+});
+
+console.log( namespace );

test/form/legacy-reified-namespace/_expected/iife.js

@@ -0,0 +1,15 @@
+(function () {
+	'use strict';
+
+	const _typeof = 'typeof';
+	const foo = 1;
+
+
+	var namespace = (Object.freeze || Object)({
+		'typeof': _typeof,
+		foo: foo
+	});
+
+	console.log( namespace );
+
+}());

test/form/legacy-reified-namespace/_expected/umd.js

@@ -0,0 +1,18 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(factory());
+}(this, (function () { 'use strict';
+
+	const _typeof = 'typeof';
+	const foo = 1;
+
+
+	var namespace = (Object.freeze || Object)({
+		'typeof': _typeof,
+		foo: foo
+	});
+
+	console.log( namespace );
+
+})));

test/form/legacy-reified-namespace/main.js

@@ -0,0 +1,3 @@
+import * as namespace from './namespace.js';
+
+console.log( namespace );

test/form/legacy-reified-namespace/namespace.js

@@ -0,0 +1,3 @@
+const _typeof = 'typeof';
+export { _typeof as typeof };
+export const foo = 1;