Jack Mallers
37c0fe6a6e
style(lint): fix lint errors
7 years ago
JimmyMow
a2b0ba3486
Merge pull request #467 from mrfelton/docs/commit-hook-help
Improve documentation on git commit hooks
7 years ago
Tom Kirkpatrick
76d8ecc15c
docs: additional documentation on git commit hooks
Add some additional documentation on our git hooks to describe how to
enable them and what they do.
7 years ago
Ben Woosley
dc32568236
Merge pull request #464 from LN-Zap/fix/undefined-lnd-log
fix(log): fix the uncaught exception by calling info on log not lnd
7 years ago
Ben Woosley
5dd198d5a6
Merge pull request #459 from Empact/style/line-length
style: Limit prettier line length to 100 chars, with 120 chars allowed for long strings and comments
7 years ago
Jack Mallers
392bb330f7
fix(log): fix the uncaught exception by calling info on log not lnd.log
7 years ago
Ben Woosley
dc29c80ad0
style(line length): Drop prettier line length from 120 to 100
Subjectively, this increases general readability, while the higher max-length
limit allows for longer strings and comments, etc.
7 years ago
Ben Woosley
4d876ae930
style(line length): Limit max length to 120, including comments, etc.
7 years ago
Ben Woosley
f87236495a
style(line length): Limit prettier line length to 120 chars
150 is a bit too long
7 years ago
Ben Woosley
074576ba6a
Merge pull request #454 from LN-Zap/fix/channel-details-in-prod
fix(channels): fix invalid assignment error that was not allowing cha…
7 years ago
Ben Woosley
71c0fa0fdc
Merge pull request #458 from Empact/lint/minimal-disable
lint: Minimize disabling of linters
7 years ago
Ben Woosley
854a073a08
Merge pull request #444 from Empact/enhance/lnd-config
Move LND settings Zap uses into the local lnd.conf
7 years ago
Ben Woosley
7ddc6a7b76
Merge pull request #452 from mrfelton/build/webpack-environments
Leverage webpack v4 modes for managing NODE_ENV settings
7 years ago
Ben Woosley
86309b1925
Merge pull request #462 from mrfelton/perf/react-icon-includes
Optimise bundle size by only importing used react icons
7 years ago
Ben Woosley
d592d77de4
Merge pull request #461 from Empact/docs/convention-link
docs: add missing convention link to CONTRIBUTING page
7 years ago
Jack Mallers
3adf4620e0
fix(channels): fix invalid assignment error for removeClicked, displayNodeName and channelStatus
7 years ago
Ben Woosley
4e963f6f30
Merge pull request #460 from Empact/lint/conflicting-style-rules
lint: Remove redundant eslint rules
7 years ago
Ben Woosley
5bc2f6e980
lint(explicit disable): Make all eslint-disable-line statements explicit
As to what they disable.
7 years ago
Tom Kirkpatrick
0c7e75eb05
perf(bundle-size): only import used react icons
The final size of renderer.prod.js is about 4.75mb. 2.35mb of this comes
from react-icons.
Update the react icon imports to import only the specific icons that we
use. This reduces the final size of renderer.prod.js by about 50%
7 years ago
Ben Woosley
3c08966fd9
lint(conflicting style rules): Remove redundant eslint rules
Indentified via eslint-config-prettier's check script.
7 years ago
Ben Woosley
28758b2e5a
docs(convention link): add missing convention link to CONTRIBUTING page
7 years ago
Ben Woosley
d5211076fd
enhance(lnd config): Move LND settings Zap uses into the local lnd.conf
This enables easy access to all lnd settings for development, and is a step
toward relying on an external configuration file that will be accessible to
users for whom the code is not.
7 years ago
Ben Woosley
acaeb5d18b
enhance(lnd config): Add the sample lnd config to resources
From:
https://github.com/lightningnetwork/lnd/blob/v0.4.2-beta/sample-lnd.conf
7 years ago
Ben Woosley
689d5bf753
lint(unnecessary disable): Remove unnecessary eslist-disable-lint statements
7 years ago
Jack Mallers
da4ae24675
fix(channels): fix invalid assignment error that was not allowing channel details to toggle open on click in production builds
7 years ago
JimmyMow
61a994591b
Merge pull request #431 from odb366/fix/onboarding-layout-ui
Fix/onboarding layout ui
7 years ago
odb366
273ec2b6c0
fix(onboarding-layout-ui): lint errors fixed
7 years ago
odb366
508ddf670b
fix(onboarding-layout-ui): fixed lint errors
7 years ago
Tom Kirkpatrick
3e60d518b2
build(webpack): remove redundant environment check
Webpack environment `mode` is defined directly in our environment
specific webpack config files. Due to this, we no longer need to
manually set `NODE_ENV` or check to ensure that it has been set.
See:
- https://webpack.js.org/concepts/mode/
7 years ago
Tom Kirkpatrick
42b08272ec
build(webpack): remove redundant NODE_ENV setting
Webpack v4 introduced a new `mode` setting, which - amongst other
things - automates the definition of the NODE_ENV environment variable.
We already had the `mode` settings set in our webpack configs so this
change is just to clean up some redundant code that is handled
automatically by this setting.
See:
- https://webpack.js.org/concepts/mode/
7 years ago
Kristiyan Lukanov
e7d6bec662
Merge branch 'master' into fix/onboarding-layout-ui
7 years ago
odb366
c4e6345c50
fix(onboarding-layout-ui): button color changed, and conflict resolved
7 years ago
JimmyMow
74f335e0de
Merge pull request #447 from odb366/fix/submit-channel-layout
fix(submit-channel-layout): refactor form layout
7 years ago
JimmyMow
49e53feb9c
Merge pull request #451 from mrfelton/build/concurrently-colour
Ensure webpack build output is in colour
7 years ago
Tom Kirkpatrick
88f4fa2f64
build(scripts): disable concurrently prettifying
pass the `--raw` flag to concurrently so that we output the raw output
of processes. This disables concurrently prettifying and provides a more
legible output for our scripts.
7 years ago
Ben Woosley
b7fead406a
Merge pull request #449 from LN-Zap/fix/slack-link
docs(slack-link): replace the expired slack link with a link that does…
7 years ago
Jack Mallers
ee95be067f
docs(contributing): update slack link to one that does not expire
7 years ago
odb366
ad7a08cfa9
fix(submit-channel-layout): width of amount field matches expected output
7 years ago
odb366
4bc9f611ae
Merge branch 'fix/submit-channel-layout' of https://github.com/odb366/zap-desktop into fix/submit-channel-layout
7 years ago
odb366
c4a6b0f8ae
fix(submit-channel-layout): refactor form layout
7 years ago
Jack Mallers
1d8a2563ab
fix(slack-link): replace the expired slack link with a link that does not expire
7 years ago
Ben Woosley
2e6e0a8f3d
Merge pull request #440 from mrfelton/build/developer-workflow
Developer workflow improvements
7 years ago
Ben Woosley
114ae4bd3d
Merge pull request #445 from mrfelton/build/use-precompiled-grpc-bindings
build: do not build grpc-node from source
7 years ago
Ben Woosley
04404e09ce
Merge pull request #448 from mrfelton/ci/appveyor
Fix build issues on AppVeyor
7 years ago
Ben Woosley
2b7c842320
Merge pull request #442 from mrfelton/docs/improvements
docs: improve documentation
7 years ago
Tom Kirkpatrick
11abf047e9
ci(appveyor): disable electron security warnings
Set ELECTRON_DISABLE_SECURITY_WARNINGS on appveyor to prevent security
warnings related to CSP from failing the tests.
7 years ago
Tom Kirkpatrick
d3cdf8e41d
ci(appveyor): build on node v8 and v10
Previously appveyor was configured to build on node versions 7 and 10.
We don't support node 7. Update to build on v8 and v10.
7 years ago
odb366
fca58025a2
fix(submit-channel-layout): refactor form layout
7 years ago
Tom Kirkpatrick
556e541278
build: do not build grpc-node from source
grpc-node provides node bindings that are specifically targeted towards
electron. Make use of these rather than force compiling grpc on install.
See https://github.com/LN-Zap/zap-desktop/issues/420
7 years ago
Tom Kirkpatrick
a569542a41
docs: improve documentation
**Readme**
- Update format to conform to `standard-readme` format
- Tidy up header section
- Add table of contents
- Add security section
- Add help section
- List maintainers
- Add contribution notes
- Add contributors list
**Contributing**
- Add table of contents
- Add contribution faq
- Add contribution guidelines
**Advanced**
- Add table of contents
7 years ago