Ben Woosley
5629da90da
Merge pull request #477 from LN-Zap/fix/p2pkh-call
fix(p2pkh): generate np2wkh instead of p2pkh
7 years ago
Ben Woosley
68bc713de8
Merge pull request #478 from mrfelton/fix/kill-lnd-on-quit
fix: kill lnd process on quit
7 years ago
Ben Woosley
926b61ba68
Merge pull request #476 from mrfelton/perf/moment-timezone
Do not bundle moment-timezone that we don't use
7 years ago
Tom Kirkpatrick
bd26d26884
fix: kill lnd process on quit
Ensure that any lnd process started by us is killed when the app quits.
Fix #470
7 years ago
Jack Mallers
afb690dd95
fix(p2pkh): generate np2wkh instead of p2pkh
7 years ago
Tom Kirkpatrick
da2d6955e3
perf(bundle-size): remove moment-timezone dep
Shaves 176.88k of final renderer.prod.js bundle size.
7 years ago
Ben Woosley
00fa22b253
Merge pull request #465 from Empact/fix/api-error-throw
fix: Don't catch api/index errors
7 years ago
Ben Woosley
1178a9dcc3
Merge pull request #466 from LN-Zap/feature/testnet-prefix-channel-balance
Feature/testnet prefix channel balance
7 years ago
JimmyMow
a2b0ba3486
Merge pull request #467 from mrfelton/docs/commit-hook-help
Improve documentation on git commit hooks
7 years ago
Tom Kirkpatrick
76d8ecc15c
docs: additional documentation on git commit hooks
Add some additional documentation on our git hooks to describe how to
enable them and what they do.
7 years ago
Jack Mallers
147a719b96
fix lint errors
7 years ago
Jack Mallers
371c152cfb
feat(channels): remove hardcode currency name in channel balance and replace with dynamic currency name
7 years ago
Ben Woosley
07ff5db0b9
fix: Don't catch api/index errors
If we catch these errors and resolve to the error itself, then `await` for that
function resolves to the error value rather than throw. Because no api currently
handles the associated errors, it is better to be noisy about these errors, by
throwing rather than returning the error object.
7 years ago
Ben Woosley
dc32568236
Merge pull request #464 from LN-Zap/fix/undefined-lnd-log
fix(log): fix the uncaught exception by calling info on log not lnd
7 years ago
Ben Woosley
5dd198d5a6
Merge pull request #459 from Empact/style/line-length
style: Limit prettier line length to 100 chars, with 120 chars allowed for long strings and comments
7 years ago
Jack Mallers
392bb330f7
fix(log): fix the uncaught exception by calling info on log not lnd.log
7 years ago
Ben Woosley
dc29c80ad0
style(line length): Drop prettier line length from 120 to 100
Subjectively, this increases general readability, while the higher max-length
limit allows for longer strings and comments, etc.
7 years ago
Ben Woosley
4d876ae930
style(line length): Limit max length to 120, including comments, etc.
7 years ago
Ben Woosley
f87236495a
style(line length): Limit prettier line length to 120 chars
150 is a bit too long
7 years ago
Ben Woosley
074576ba6a
Merge pull request #454 from LN-Zap/fix/channel-details-in-prod
fix(channels): fix invalid assignment error that was not allowing cha…
7 years ago
Ben Woosley
71c0fa0fdc
Merge pull request #458 from Empact/lint/minimal-disable
lint: Minimize disabling of linters
7 years ago
Ben Woosley
854a073a08
Merge pull request #444 from Empact/enhance/lnd-config
Move LND settings Zap uses into the local lnd.conf
7 years ago
Ben Woosley
7ddc6a7b76
Merge pull request #452 from mrfelton/build/webpack-environments
Leverage webpack v4 modes for managing NODE_ENV settings
7 years ago
Ben Woosley
86309b1925
Merge pull request #462 from mrfelton/perf/react-icon-includes
Optimise bundle size by only importing used react icons
7 years ago
Ben Woosley
d592d77de4
Merge pull request #461 from Empact/docs/convention-link
docs: add missing convention link to CONTRIBUTING page
7 years ago
Jack Mallers
3adf4620e0
fix(channels): fix invalid assignment error for removeClicked, displayNodeName and channelStatus
7 years ago
Ben Woosley
4e963f6f30
Merge pull request #460 from Empact/lint/conflicting-style-rules
lint: Remove redundant eslint rules
7 years ago
Ben Woosley
5bc2f6e980
lint(explicit disable): Make all eslint-disable-line statements explicit
As to what they disable.
7 years ago
Tom Kirkpatrick
0c7e75eb05
perf(bundle-size): only import used react icons
The final size of renderer.prod.js is about 4.75mb. 2.35mb of this comes
from react-icons.
Update the react icon imports to import only the specific icons that we
use. This reduces the final size of renderer.prod.js by about 50%
7 years ago
Ben Woosley
3c08966fd9
lint(conflicting style rules): Remove redundant eslint rules
Indentified via eslint-config-prettier's check script.
7 years ago
Ben Woosley
28758b2e5a
docs(convention link): add missing convention link to CONTRIBUTING page
7 years ago
Ben Woosley
d5211076fd
enhance(lnd config): Move LND settings Zap uses into the local lnd.conf
This enables easy access to all lnd settings for development, and is a step
toward relying on an external configuration file that will be accessible to
users for whom the code is not.
7 years ago
Ben Woosley
acaeb5d18b
enhance(lnd config): Add the sample lnd config to resources
From:
https://github.com/lightningnetwork/lnd/blob/v0.4.2-beta/sample-lnd.conf
7 years ago
Ben Woosley
689d5bf753
lint(unnecessary disable): Remove unnecessary eslist-disable-lint statements
7 years ago
Jack Mallers
da4ae24675
fix(channels): fix invalid assignment error that was not allowing channel details to toggle open on click in production builds
7 years ago
JimmyMow
61a994591b
Merge pull request #431 from odb366/fix/onboarding-layout-ui
Fix/onboarding layout ui
7 years ago
odb366
273ec2b6c0
fix(onboarding-layout-ui): lint errors fixed
7 years ago
odb366
508ddf670b
fix(onboarding-layout-ui): fixed lint errors
7 years ago
Tom Kirkpatrick
3e60d518b2
build(webpack): remove redundant environment check
Webpack environment `mode` is defined directly in our environment
specific webpack config files. Due to this, we no longer need to
manually set `NODE_ENV` or check to ensure that it has been set.
See:
- https://webpack.js.org/concepts/mode/
7 years ago
Tom Kirkpatrick
42b08272ec
build(webpack): remove redundant NODE_ENV setting
Webpack v4 introduced a new `mode` setting, which - amongst other
things - automates the definition of the NODE_ENV environment variable.
We already had the `mode` settings set in our webpack configs so this
change is just to clean up some redundant code that is handled
automatically by this setting.
See:
- https://webpack.js.org/concepts/mode/
7 years ago
Kristiyan Lukanov
e7d6bec662
Merge branch 'master' into fix/onboarding-layout-ui
7 years ago
odb366
c4e6345c50
fix(onboarding-layout-ui): button color changed, and conflict resolved
7 years ago
JimmyMow
74f335e0de
Merge pull request #447 from odb366/fix/submit-channel-layout
fix(submit-channel-layout): refactor form layout
7 years ago
JimmyMow
49e53feb9c
Merge pull request #451 from mrfelton/build/concurrently-colour
Ensure webpack build output is in colour
7 years ago
Tom Kirkpatrick
88f4fa2f64
build(scripts): disable concurrently prettifying
pass the `--raw` flag to concurrently so that we output the raw output
of processes. This disables concurrently prettifying and provides a more
legible output for our scripts.
7 years ago
Ben Woosley
b7fead406a
Merge pull request #449 from LN-Zap/fix/slack-link
docs(slack-link): replace the expired slack link with a link that does…
7 years ago
Jack Mallers
ee95be067f
docs(contributing): update slack link to one that does not expire
7 years ago
odb366
ad7a08cfa9
fix(submit-channel-layout): width of amount field matches expected output
7 years ago
odb366
4bc9f611ae
Merge branch 'fix/submit-channel-layout' of https://github.com/odb366/zap-desktop into fix/submit-channel-layout
7 years ago
odb366
c4a6b0f8ae
fix(submit-channel-layout): refactor form layout
7 years ago