JimmyMow
61a994591b
Merge pull request #431 from odb366/fix/onboarding-layout-ui
Fix/onboarding layout ui
7 years ago
odb366
273ec2b6c0
fix(onboarding-layout-ui): lint errors fixed
7 years ago
odb366
508ddf670b
fix(onboarding-layout-ui): fixed lint errors
7 years ago
Kristiyan Lukanov
e7d6bec662
Merge branch 'master' into fix/onboarding-layout-ui
7 years ago
odb366
c4e6345c50
fix(onboarding-layout-ui): button color changed, and conflict resolved
7 years ago
JimmyMow
74f335e0de
Merge pull request #447 from odb366/fix/submit-channel-layout
fix(submit-channel-layout): refactor form layout
7 years ago
JimmyMow
49e53feb9c
Merge pull request #451 from mrfelton/build/concurrently-colour
Ensure webpack build output is in colour
7 years ago
Tom Kirkpatrick
88f4fa2f64
build(scripts): disable concurrently prettifying
pass the `--raw` flag to concurrently so that we output the raw output
of processes. This disables concurrently prettifying and provides a more
legible output for our scripts.
7 years ago
Ben Woosley
b7fead406a
Merge pull request #449 from LN-Zap/fix/slack-link
docs(slack-link): replace the expired slack link with a link that does…
7 years ago
Jack Mallers
ee95be067f
docs(contributing): update slack link to one that does not expire
7 years ago
odb366
ad7a08cfa9
fix(submit-channel-layout): width of amount field matches expected output
7 years ago
odb366
4bc9f611ae
Merge branch 'fix/submit-channel-layout' of https://github.com/odb366/zap-desktop into fix/submit-channel-layout
7 years ago
odb366
c4a6b0f8ae
fix(submit-channel-layout): refactor form layout
7 years ago
Jack Mallers
1d8a2563ab
fix(slack-link): replace the expired slack link with a link that does not expire
7 years ago
Ben Woosley
2e6e0a8f3d
Merge pull request #440 from mrfelton/build/developer-workflow
Developer workflow improvements
7 years ago
Ben Woosley
114ae4bd3d
Merge pull request #445 from mrfelton/build/use-precompiled-grpc-bindings
build: do not build grpc-node from source
7 years ago
Ben Woosley
04404e09ce
Merge pull request #448 from mrfelton/ci/appveyor
Fix build issues on AppVeyor
7 years ago
Ben Woosley
2b7c842320
Merge pull request #442 from mrfelton/docs/improvements
docs: improve documentation
7 years ago
Tom Kirkpatrick
11abf047e9
ci(appveyor): disable electron security warnings
Set ELECTRON_DISABLE_SECURITY_WARNINGS on appveyor to prevent security
warnings related to CSP from failing the tests.
7 years ago
Tom Kirkpatrick
d3cdf8e41d
ci(appveyor): build on node v8 and v10
Previously appveyor was configured to build on node versions 7 and 10.
We don't support node 7. Update to build on v8 and v10.
7 years ago
odb366
fca58025a2
fix(submit-channel-layout): refactor form layout
7 years ago
Tom Kirkpatrick
556e541278
build: do not build grpc-node from source
grpc-node provides node bindings that are specifically targeted towards
electron. Make use of these rather than force compiling grpc on install.
See https://github.com/LN-Zap/zap-desktop/issues/420
7 years ago
Tom Kirkpatrick
a569542a41
docs: improve documentation
**Readme**
- Update format to conform to `standard-readme` format
- Tidy up header section
- Add table of contents
- Add security section
- Add help section
- List maintainers
- Add contribution notes
- Add contributors list
**Contributing**
- Add table of contents
- Add contribution faq
- Add contribution guidelines
**Advanced**
- Add table of contents
7 years ago
Tom Kirkpatrick
0846bcb772
style(lint): lint and format all code
7 years ago
Tom Kirkpatrick
4ed944adac
build(lint): validate commit message format
Automatically validate commit messages according to the Conventional
Commit standard in a git commit-msg hook.
This functionality is optional and can be enabled by adding a .opt-in
file with a line `commit-msg`.
See:
- http://conventionalcommits.org/
- https://github.com/marionebl/commitlint
7 years ago
Tom Kirkpatrick
0a11c47329
build(lint): lint/format in git pre-commit hook
Currently we use eslint and prettier to lint and format code. However,
running the linter is a manual step that is easy to forget.
To improve this we run our lint scripts in a git pre-commit hook. This
functionality is optional and can be enabled by adding a .opt-in file
with a line `pre-commit`.
7 years ago
Tom Kirkpatrick
9847cdb82f
build(lint): auto code formatting with prettier
Currently we use eslint to lint code, but formatting the code according
to our ruleset is a manual process.
Implement `prettier` so that code is automatically formatted as part of
our development workflow.
See https://prettier.io/
7 years ago
Ben Woosley
e942d3c3bc
enhance(comments): Refer to the standard github page for rpc.proto
Rather than the raw
7 years ago
Ben Woosley
68b4749f3e
enhance(comments): Record that the current rpc.proto file is from lnd release 0.4.2
7 years ago
Ben Woosley
751a022e3c
Merge pull request #437 from Empact/enhance/no-console
Convert remaining console statements to log or throw, enable no-console linter
7 years ago
Ben Woosley
2cebba7a57
enhance(linting): Enable the eslint:recommended rules
Among other things, this makes no-console an error rather than a warning.
https://eslint.org/docs/rules/no-console
Given that we now have a proper logging facility, good to prevent incidental
introduction in the future.
7 years ago
Ben Woosley
06595b1ea4
enhance(test): Drop pessimistic printing of logs that shouldn't be there
This test code is unnecessary in the common case and can be revived if the test
fails.
7 years ago
Ben Woosley
81e1b2ec78
enhance(logging): Output webpack errors to the main log
Rather than console.log
In case of CheckNodeEnv, throw rather than console.log and exit.
7 years ago
Ben Woosley
e2ac8729d1
enhance(logging); Output app/lnd logs to the lnd log, rather than console.log
7 years ago
Ben Woosley
4ffe3e1801
Merge pull request #438 from Empact/fix/lnd-log-level
Fix lndLogGetLevel to apply the most-recent log level when none is detected
7 years ago
Ben Woosley
a22a2a5397
Merge pull request #428 from mrfelton/feat/electron-2
Update electron to v2.x
7 years ago
Ben Woosley
66fb3af09d
Merge pull request #395 from mrfelton/fix/channel-search-handle-no-results
fix(channels): do not show suggested nodes on empty search
7 years ago
Ben Woosley
0602fbe7ca
fix(lnd log level): Fix lndLogGetLevel to apply the most-recent log level when none is detected
In some cases, multi-line log output was output at its value for the first line,
but in the trace log in following lines. For example, in this output:
zap:lnd [DBG] 2018-06-17 18:30:35.051 [DBG] CRTR: New channel update applied: (*channeldb.ChannelEdgePolicy)(0xc420e74310)({ +0ms
zap:lnd [DBG] SigBytes: ([]uint8) (len=71 cap=71) { +0ms
zap:lnd [DBG] }, +0ms
zap:lnd [DBG] sig: (*btcec.Signature)(<nil>), +0ms
zap:lnd [DBG] ChannelID: (uint64) 1423834572626526208, +0ms
zap:lnd [DBG] LastUpdate: (time.Time) 2018-06-17 18:30:26 -0500 CDT, +0ms
zap:lnd [DBG] Flags: (lnwire.ChanUpdateFlag) 1, +0ms
zap:lnd [DBG] TimeLockDelta: (uint16) 6, +0ms
zap:lnd [DBG] MinHTLC: (lnwire.MilliSatoshi) 1000 mSAT, +0ms
zap:lnd [DBG] FeeBaseMSat: (lnwire.MilliSatoshi) 1 mSAT, +0ms
zap:lnd [DBG] FeeProportionalMillionths: (lnwire.MilliSatoshi) 10 mSAT, +0ms
zap:lnd [DBG] Node: (*channeldb.LightningNode)(<nil>), +0ms
zap:lnd [DBG] db: (*channeldb.DB)(<nil>) +1ms
zap:lnd [DBG] }) +0ms
zap:lnd [DBG] +0ms
Previously the first line would be marked DBG, while the others were marked TRC.
7 years ago
Ben Woosley
254807db0a
Merge pull request #436 from mrfelton/feat/logging
Improve log readability and allow control over what is logged
7 years ago
Tom Kirkpatrick
615ed52e7a
ci(travis): disable security warnings
Set ELECTRON_DISABLE_SECURITY_WARNINGS on travis to prevent security
warnings related to CSP from failing the tests.
7 years ago
Tom Kirkpatrick
f460542e25
fix(security): content security policy
Set up an initial Content-Security-Policy that limits resources
loading capabilities to those locations that we expect to load from.
Note: This currently includes three following remote URLs:
*content:*
- https://api.coinmarketcap.com
- http://zap.jackmallers.com
- https://testnet-api.smartbit.com.au ;
*fonts/styles:*
- https://fonts.googleapis.com
- https://s3.amazonaws.com
- https://fonts.gstatic.com
7 years ago
Tom Kirkpatrick
814252caee
build(electron): update to electron v2.0.2
7 years ago
Ben Woosley
e34dbe52db
Merge pull request #434 from mrfelton/fix/installtion-instructions
Remove redundant install steps
7 years ago
Tom Kirkpatrick
4a535be142
feat(logging): more readable logs
Use debug-logger to provide a more comprehensive and flexible logging
solution. Use two separate log handlers to provide separation between
electron and and lnd logs.
7 years ago
Ben Woosley
c4d701c156
Merge pull request #433 from mrfelton/fix/lnd-output-parsing
More reliable lnd log parsing
7 years ago
Ben Woosley
742a3dd26b
Merge pull request #427 from Empact/network
Prefix testnet units with 't'
7 years ago
Ben Woosley
ee4157b49b
Merge pull request #429 from Empact/enhance/onboarding
Don't run onboarding if LND is already running locally
7 years ago
Ben Woosley
a1873ead1c
Merge pull request #435 from mrfelton/build/unneeded-concurrently
Remove unneeded call to concurrently
7 years ago
Tom Kirkpatrick
87ef962ef2
build(scripts): remove unneeded call to concurrently
There is an unneeded call to `concurrently` in the `npm run dev` script.
This causes things that should be output in colour (eg debug messages
when running with DEBUG=*) to not be output in colour which makes
debugging things harder than it should be.
This was in place because previously lnd was being started up externally
in the `npm run dev` script at the same time as starting up the app. But
we now use spawn from within the app to start up lnd.
The call to `concurrently` is no longer needed.
See d8c5623e01
7 years ago
Tom Kirkpatrick
09fe241a7e
docs(advanced): remove redundant install steps
Remove the `install-grpc` installation step as it is redundant.
See #420
7 years ago