Merge pull request #831 from eordano/review/block

Coverage for block and blockheader

lib/block.js

@@ -12,7 +12,6 @@ var Transaction = require('./transaction');
 var Varint = require('./encoding/varint');
 
 /**
- * @class Block
  * Instantiate a Block from a Buffer, JSON object, or Object with
  * the properties of the Block
  *

test/block.js

@@ -3,6 +3,7 @@
 var bitcore = require('..');
 var BN = require('../lib/crypto/bn');
 var BufferReader = bitcore.encoding.BufferReader;
+var BufferWriter = bitcore.encoding.BufferWriter;
 var BlockHeader = bitcore.BlockHeader;
 var Block = bitcore.Block;
 var chai = require('chai');
@@ -102,6 +103,11 @@ describe('Block', function() {
       should.exist(block.txs);
     });
 
+    it('accepts an object as argument', function() {
+      var block = Block.fromRawBlock(dataRawBlockBuffer);
+      Block.fromJSON(block.toObject()).should.exist();
+    });
+
   });
 
   describe('#toJSON', function() {
@@ -161,6 +167,12 @@ describe('Block', function() {
       block.toBufferWriter().concat().toString('hex').should.equal(blockhex);
     });
 
+    it('doesn\'t create a bufferWriter if one provided', function() {
+      var writer = new BufferWriter();
+      var block = Block.fromBuffer(blockbuf);
+      block.toBufferWriter(writer).should.equal(writer);
+    });
+
   });
 
   describe('#_getHash', function() {

test/blockheader.js

@@ -3,6 +3,8 @@
 var bitcore = require('..');
 var BN = require('../lib/crypto/bn');
 var BufferReader = bitcore.encoding.BufferReader;
+var BufferWriter = bitcore.encoding.BufferWriter;
+
 var BlockHeader = bitcore.BlockHeader;
 var fs = require('fs');
 var should = require('chai').should();
@@ -161,6 +163,12 @@ describe('BlockHeader', function() {
       BlockHeader.fromBuffer(bhbuf).toBufferWriter().concat().toString('hex').should.equal(bhhex);
     });
 
+    it('doesn\'t create a bufferWriter if one provided', function() {
+      var writer = new BufferWriter();
+      var blockHeader = BlockHeader.fromBuffer(bhbuf);
+      blockHeader.toBufferWriter(writer).should.equal(writer);
+    });
+
   });
 
   describe('#inspect', function() {
@@ -226,4 +234,9 @@ describe('BlockHeader', function() {
 
   });
 
+  it('coverage: caches the "_id" property', function() {
+      var blockHeader = BlockHeader.fromRawBlock(dataRawBlockBuffer);
+      blockHeader.id.should.equal(blockHeader.id);
+  });
+
 });