Browse Source

test: fix pummel/test-net-connect-econnrefused

The test relied on a peculiarity of process.nextTick() that was changed in
commit 4e5fe2d. Before that commit, each nextTick callback corresponded with
the event loop moving forward one tick. That's no longer the case.
v0.9.1-release
Ben Noordhuis 13 years ago
parent
commit
6b588007df
  1. 19
      test/pummel/test-net-connect-econnrefused.js

19
test/pummel/test-net-connect-econnrefused.js

@ -27,7 +27,7 @@ var net = require('net');
var ROUNDS = 5; var ROUNDS = 5;
var ATTEMPTS_PER_ROUND = 200; var ATTEMPTS_PER_ROUND = 200;
var rounds = 0; var rounds = 1;
var reqs = 0; var reqs = 0;
pummel(); pummel();
@ -39,21 +39,20 @@ function pummel() {
net.createConnection(common.PORT).on('error', function(err) { net.createConnection(common.PORT).on('error', function(err) {
assert.equal(err.code, 'ECONNREFUSED'); assert.equal(err.code, 'ECONNREFUSED');
if (--pending > 0) return; if (--pending > 0) return;
if (++rounds < ROUNDS) return pummel(); if (rounds == ROUNDS) return check();
check(); rounds++;
pummel();
}); });
reqs++; reqs++;
} }
} }
function check() { function check() {
process.nextTick(function() { setTimeout(function() {
process.nextTick(function() { assert.equal(process._getActiveRequests().length, 0);
assert.equal(process._getActiveRequests().length, 0); assert.equal(process._getActiveHandles().length, 1); // the timer
assert.equal(process._getActiveHandles().length, 0); check_called = true;
check_called = true; }, 0);
});
});
} }
var check_called = false; var check_called = false;

Loading…
Cancel
Save