lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Domenic Denicola	7afdba6e0b	vm, core, module: re-do vm to fix known issues As documented in #3042 and in [1], the existing vm implementation has many problems. All of these are solved by @brianmcd's [contextify][2] package. This commit uses contextify as a conceptual base and its code core to overhaul the vm module and fix its many edge cases and caveats. Functionally, this fixes #3042. In particular: - A context is now indistinguishable from the object it is based on (the "sandbox"). A context is simply a sandbox that has been marked by the vm module, via `vm.createContext`, with special internal information that allows scripts to be run inside of it. - Consequently, items added to the context from anywhere are immediately visible to all code that can access that context, both inside and outside the virtual machine. This commit also smooths over the API very slightly: - Parameter defaults are now uniformly triggered via `undefined`, per ES6 semantics and previous discussion at [3]. - Several undocumented and problematic features have been removed, e.g. the conflation of `vm.Script` with `vm` itself, and the fact that `Script` instances also had all static `vm` methods. The API is now exactly as documented (although arguably the existence of the `vm.Script` export is not yet documented, just the `Script` class itself). In terms of implementation, this replaces node_script.cc with node_contextify.cc, which is derived originally from [4] (see [5]) but has since undergone extensive modifications and iterations to expose the most useful C++ API and use the coding conventions and utilities of Node core. The bindings exposed by `process.binding('contextify')` (node_contextify.cc) replace those formerly exposed by `process.binding('evals')` (node_script.cc). They are: - ContextifyScript(code, [filename]), with methods: - runInThisContext() - runInContext(sandbox, [timeout]) - makeContext(sandbox) From this, the vm.js file builds the entire documented vm module API. node.js and module.js were modified to use this new native binding, or the vm module itself where possible. This introduces an extra line or two into the stack traces of module compilation (and thus into most stack traces), explaining the changed tests. The tests were also updated slightly, with all vm-related simple tests consolidated as test/simple/test-vm-* (some of them were formerly test/simple/test-script-*). At the same time they switched from `common.debug` to `console.error` and were updated to use `assert.throws` instead of rolling their own error-testing methods. New tests were also added, of course, demonstrating the new capabilities and fixes. [1]: http://nodejs.org/docs/v0.10.16/api/vm.html#vm_caveats [2]: https://github.com/brianmcd/contextify [3]: https://github.com/joyent/node/issues/5323#issuecomment-20250726 [4]: `bf123f3ef9/src/contextify.cc` [5]: https://gist.github.com/domenic/6068120	11 years ago
Ben Noordhuis	e772a7deaf	build: fix --without-ssl build Build breakage accidentally introduced in `8e29ce9` during code cleanup. HAVE_OPENSSL is always defined (as either 0 or 1) so use #if rather than #ifdef. Fixes #5979.	11 years ago
Fedor Indutny	8e29ce9f13	src: lint c++ code	11 years ago
Ben Noordhuis	d4c14c1fe5	src: add libuv bindings module Exports: * all UV_E* error codes * a uv_err_name() binding	11 years ago
Nathan Rajlich	567c72b8c5	configure: fix the --without-ssl option Closes #5807.	11 years ago
Trevor Norris	8f3f9f7830	smalloc: initial implementation smalloc is a simple utility for quickly allocating external memory onto js objects. This will be used to centralize how memory is managed in node, and will become the backer for Buffers. So in the future crypto's SlabBuffer, stream's SlabAllocator will be removed. Note on the js API: because no arguments are optional the order of arguments have been placed to match their cc counterparts as closely as possible.	12 years ago
Fedor Indutny	03e008ddb8	tls_wrap: embed TLS encryption into streamwrap	12 years ago
Dean McNamee	3f75454426	typed arrays: don't declare as module TypedArrays is not a module, it is attached to the global object. Don't register it with Node's module system.	12 years ago
Bert Belder	600a6468dc	process: use uv_signal instead of ev_signal	12 years ago
Ben Noordhuis	74a8215a86	Revert support for isolates. It was decided that the performance benefits that isolates offer (faster spin-up times for worker processes, faster inter-worker communication, possibly a lower memory footprint) are not actual bottlenecks for most people and do not outweigh the potential stability issues and intrusive changes to the code base that first-class support for isolates requires. Hence, this commit backs out all isolates-related changes. Good bye, isolates. We hardly knew ye.	13 years ago
Mikael Bourges-Sevenier	5b05429bf0	typed arrays: add Buffer -> TypedArray constructor - create a typed array from a node::Buffer object - update TypedArray::set() to spec - add TypedArray::get() method	13 years ago
Ryan Dahl	5fc0c27d5c	move isolate V8 functions out of node.cc	13 years ago
Ryan Dahl	533a455274	move isolate V8 functions out of node.cc	13 years ago
Ryan Dahl	cdf5d91fe5	Remove tty_legacy	13 years ago
Ryan Dahl	58e892dadd	Remove dns_legacy	13 years ago
Ryan Dahl	96e423a665	Remove child_process_legacy	13 years ago
Ryan Dahl	be0bb2dc13	Remove net_legacy timers_legacy	13 years ago
Ryan Dahl	311fe737e8	Upgrade libuv to 60c639f Also remove unused src/stdio_wrap.cc	13 years ago
Igor Zinkovsky	8fe5712477	fs watcher binding	13 years ago
Ryan Dahl	c1ae6ea2f2	Add TTYWrap	13 years ago
isaacs	5b8e1dabbc	Initial pass at zlib bindings	13 years ago
Ben Noordhuis	cbd4033619	dgram: integrate libuv UDP support	13 years ago
Peter Bright	6ac8c55989	Make MSVS build. MSVS settings don't actually need to be guarded by conditions. gyp will do the right thing.	13 years ago
Ryan Dahl	8ace421bfd	Complete removal of node_child_process_win32.cc	13 years ago
Ryan Dahl	f01b241057	add wrapper for uv_spawn process.binding('process_wrap')	13 years ago
Igor Zinkovsky	187fe27a6e	stdio binding + javascript to enable process.stdin.listen()	13 years ago
Ryan Dahl	cc0f608c7c	Add pipe_wrap	13 years ago
Bert Belder	858f23094e	Bindings for libuv-integrated c-ares	13 years ago
Ryan Dahl	062759194b	Initial binding to uv_tcp_t	14 years ago
Bert Belder	406f44a86b	Build on windows again	14 years ago
Ryan Dahl	9d1bad8960	Implement new wrap for uv timer	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Bert Belder	0a2f1cb334	Child processes	14 years ago
Bert Belder	b4510d57dc	There is no child process support for windows yet	14 years ago
Brian White	f1762ff815	Add os module and getHostname	14 years ago
Paul Querna	870aa3d97f	Move evals to extension module.	14 years ago
Paul Querna	ace2be8aa6	Move the Stat structure functions to node_file.cc from node.cc, so we can convert fs to a module.	14 years ago
Paul Querna	82daa46e26	Move Buffer to extension model.	14 years ago
Paul Querna	4f7f43762d	Move child process to extension model.	14 years ago
Paul Querna	e65c27062f	Move http parser to extension model.	14 years ago
Paul Querna	e51aef7f3c	Move signal_watcher to extension model.	14 years ago
Paul Querna	208290b524	Move cares to extension model	14 years ago
Paul Querna	e5bb8abc9d	Move stdio to extension model.	14 years ago
Paul Querna	30dadfc033	Register builtin extensions via a macro, rather than a manual strcmp Set the stage for making the builtin modules more dynamic. Note: this only converts crypto and net, I will add more extensions in a later commit. * node.h: Add utility macro for converting macro values to strings. * node.h: Include the actual module name inside the module structure, not just the file it was built from. * node.h: New Macro, NODE_MODULE_DECL, for declaring an external reference to a module structure. * node_extensions.cc: New File, implements get_builtin_module, which iterates over the module structures that are compiled into node. * node.cc(node::Binding): Use the new module lookup function to find modules. * node_{net,crypto}.c: Add NODE_MODULEs to generate the module structure.	14 years ago

43 Commits (16a402c0b5444b167887a20bb44c2ab53aacb97c)