Kyle Farnung
f8dd1ac918
doc: add kfarnung to collaborators
PR-URL: https://github.com/nodejs/node/pull/16108
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
7 years ago
Adil L
2badc6301e
test: use common.fixtures module for file path
PR-URL: https://github.com/nodejs/node/pull/16017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
7 years ago
Ben Noordhuis
fca31be833
src: replace manual memory mgmt with std::string
PR-URL: https://github.com/nodejs/node/pull/15782
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
7 years ago
Kinnan Kwok
84579b1d7d
test: fix race condition in addon test
PR-URL: https://github.com/nodejs/node/pull/16037
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
7 years ago
Joyee Cheung
7d974c5536
doc: mention collaboration summit in onboarding.md
PR-URL: https://github.com/nodejs/node/pull/16079
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
7 years ago
Joyee Cheung
0a64a6a882
doc: document the benchmark CI
PR-URL: https://github.com/nodejs/node/pull/16086
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
7 years ago
Matteo Collina
9bc4f86201
crypto: make createXYZ inlineable
This commit increase by around 10% hot code paths that are hitting
createXYZ functions. Before this change the createXYZ called the XYZ
constructor without new.
PR-URL: https://github.com/nodejs/node/pull/16067
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Minya Liang
9f98989484
tools: replace concat with template literals
PR-URL: https://github.com/nodejs/node/pull/16046
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Lance Ball <lball@redhat.com>
7 years ago
Charles T Wall III
be3ac440dc
test: create benchmark test for misc and module
PR-URL: https://github.com/nodejs/node/pull/16044
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Chowdhurian
6a9fd06173
test: include expected result in error messages
PR-URL: https://github.com/nodejs/node/pull/16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Maurice Hayward
abf8bae475
test: use fixtures module
PR-URL: https://github.com/nodejs/node/pull/16034
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
tabulatedreams
5e93df6840
test: replace fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/16036
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
gitHubTracey
506a5f75f8
test: replace concat with template literals
PR-URL: https://github.com/nodejs/node/pull/15885
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
ryshep111
92d326994d
test: clarify assertion failure
PR-URL: https://github.com/nodejs/node/pull/15889
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Robin Lungwitz
b5f3054eb6
test: use fixtures.readKey
Replace the common.fixturesDir by fixtures.readKey
in http2 subsystem test 'server startup'.
PR-URL: https://github.com/nodejs/node/pull/15892
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Ivan Etchart
c11a30dc51
test: replace fixturesDir with fixtures module
`test/parallel/test-tls-ecdh.js` was loading fixture keys using
`common.fixturesDir`. Now it's using `fixtures.readKey` instead.
PR-URL: https://github.com/nodejs/node/pull/15893
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Rafal Leszczynski
c0c5e262dd
test: cleanup test-buffer-sharedarraybuffer
remove third argument `0` from calls to `assert.deepStrictEqual`
PR-URL: https://github.com/nodejs/node/pull/15896
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Savio Lucena
de2f4ea105
test: change fixturesDir to fixtures.path
PR-URL: https://github.com/nodejs/node/pull/15902
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
creisle
4a1359fe1d
test: changed fixtures require
PR-URL: https://github.com/nodejs/node/pull/15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Alex McKenzie
585c1199a2
test: replaced fixturesDir with fixtures module
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module in the path-makelong test.
PR-URL: https://github.com/nodejs/node/pull/15908
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Colin Leong
d00bb87cc7
test: replace string concatenation with templates
PR-URL: https://github.com/nodejs/node/pull/15903
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
7 years ago
Emily Platzer
47d80384f9
test: updated error message
PR-URL: https://github.com/nodejs/node/pull/15906
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
jmcgui05
b2e46c5b54
test: assert.strictEqual using template literals
PR-URL: https://github.com/nodejs/node/pull/15944
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Ben Michel
17857d4fc9
test: use common.fixtures in tls test
PR-URL: https://github.com/nodejs/node/pull/15965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
7 years ago
Sushil Tailor
3953164e42
test: replace error msg w/ template literal
PR-URL: https://github.com/nodejs/node/pull/15910
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Daniele Lisi
0662ebeef9
test: add NODE_UNIQUE_ID value to err message
PR-URL: https://github.com/nodejs/node/pull/15914
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Rob Paton
66a990b5ed
test: replace string concatenation with template
PR-URL: https://github.com/nodejs/node/pull/15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
nodexpertsdev
d4fbffded4
test: change concatenation to template literal
PR-URL: https://github.com/nodejs/node/pull/15916
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Gene Wu
c80d9d6a93
test: improve asset msg in test
Add result to part of assert message.
PR-URL: https://github.com/nodejs/node/pull/15918
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
penDerGraft
261ae7f58a
test: replace fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15919
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
7 years ago
Justin Lee
721f6df705
test: remove message from asserts
PR-URL: https://github.com/nodejs/node/pull/15920
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Pavel Pomerantsev
0fbe0a02df
test: improve an error message
PR-URL: https://github.com/nodejs/node/pull/15921
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Uttam Pawar
b8b248a9b3
test: added string_decoder.js a parallel test
PR-URL: https://github.com/nodejs/node/pull/15923
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Joe Grace
c4178abc64
test: use fixtures module instead of common
PR-URL: https://github.com/nodejs/node/pull/15925
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Charlie Duong
56c0e7d10f
test: replace fixtureDir with fixtures module
This commit replaces the usage of common.fixturesDir with
fixtures.path.
PR-URL: https://github.com/nodejs/node/pull/15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
7 years ago
suraiyah
e8bf4d5dea
doc: fix macosx-firewall suggestion BUILDING
Adding back the changes made by commit# 791d560
, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d0
, but they are still applicable.
PR-URL: https://github.com/nodejs/node/pull/15829
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
7 years ago
Alex McKenzie
0e1a9fafdd
test: replaced fixturesDir with fixtures module
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15881
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
7 years ago
Christopher Choi
b5e8ae4ff8
test: use common.fixtures module
Replace common.fixturesDir with usage of the common.fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Paul Milham
7a8d51c079
test: replaced literals in errors with templates
PR-URL: https://github.com/nodejs/node/pull/15911
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Russell Dempsey
beb23570dc
test: display better error message for assertion
This commit makes understanding assertion failures easier by
displaying the values that failed the assertion.
PR-URL: https://github.com/nodejs/node/pull/15883
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
7 years ago
heeeunkimmm
3f95a8a69e
test: changed buffer-zero output
Added interpolated strings to display the error value
PR-URL: https://github.com/nodejs/node/pull/15926
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Alex McKenzie
8baa325185
test: replaced fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15927
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Faisal Yaqoob
ba6049f7f9
test: remove literal error messages
Assertions will now print the values that caused the assertions
to fail.
PR-URL: https://github.com/nodejs/node/pull/15928
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Daniel Kostro
96221c2471
test: refactor test to use the fixtures module
PR-URL: https://github.com/nodejs/node/pull/15934
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
7 years ago
Greg Matthews
2bf182dc46
test: replace fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Alice Tsui
f96745a4d3
test: modify test messages to template literals
PR-URL: https://github.com/nodejs/node/pull/15931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
7 years ago
BradLarson
3f5f847ed1
test: replace common.fixturesDir with fixture
PR-URL: https://github.com/nodejs/node/pull/15940
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
7 years ago
joanne-jjb
31ab2ebbde
test: changes to use template literal
PR-URL: https://github.com/nodejs/node/pull/15937
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
7 years ago
Govee91
dd1592020b
tools: use more template literals
PR-URL: https://github.com/nodejs/node/pull/15942
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 years ago
Mujtaba Al-Tameemi
3a265556ec
test: replace fixturesDir with fixtures
PR-URL: https://github.com/nodejs/node/pull/15949
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
7 years ago